Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hexagon_benchmarks app for CMake builds #8069

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

prasmish
Copy link
Contributor

@prasmish prasmish commented Feb 6, 2024

This PR addresses the issue raised in #5374 regarding the lack of CMake support for hexagon_benchmark. Specifically, it introduces CMake build support for the hexagon_benchmark app which was previously missing.

During the process of adding this support, I observed that the sobel test was not building correctly with the target host-hvx. To keep this PR focused and manageable, the sobel test has been temporarily removed from this CMake script. A separate PR will be raised to rectify this issue and reintroduce the sobel test.

Copy link
Contributor

@steven-johnson steven-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this fix! LGTM pending green.

@steven-johnson
Copy link
Contributor

FAILED: hexagon_benchmarks/dilate3x3.generator 
: && /usr/bin/g++-9 -O3 -DNDEBUG -lc++abi hexagon_benchmarks/CMakeFiles/dilate3x3.generator.dir/dilate3x3_generator.cpp.o hexagon_benchmarks/CMakeFiles/dilate3x3.generator.dir/home/halidenightly/build_bot/worker/halide-testbranch-main-llvm17-x86-64-linux-cmake/halide-install/share/tools/GenGen.cpp.o -o hexagon_benchmarks/dilate3x3.generator  -Wl,-rpath,/home/halidenightly/build_bot/worker/halide-testbranch-main-llvm17-x86-64-linux-cmake/halide-install/lib  /home/halidenightly/build_bot/worker/halide-testbranch-main-llvm17-x86-64-linux-cmake/halide-install/lib/libHalide.so.18.0.0  -ldl && :
/usr/bin/ld: cannot find -lc++abi

@prasmish
Copy link
Contributor Author

prasmish commented Feb 7, 2024

Earlier, I was building Halide with Clang, which led to a minor issue here. I’ve now eliminated an unneeded flag (-lc++abi) and now it should build smoothly.

@steven-johnson
Copy link
Contributor

Failures are unrelated

@steven-johnson steven-johnson merged commit 78a0762 into halide:main Feb 7, 2024
17 of 19 checks passed
ardier pushed a commit to ardier/Halide-mutation that referenced this pull request Mar 3, 2024
* Add hexagon_benchmarks app for CMake builds

* Removed unnecessary -lc++abi flag from GCC build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants