Insert apparently-missing break; in IREquality.cpp

[steven-johnson]

No description provided.

[steven-johnson]

Maybe time to enable -Wimplicit-fallthrough

[abadams]

yikes

[abadams]

Funnily enough, this could not have caused a problem other than making a redundant check, which is why no tests failed, but that's only because GE has the same layout as GT.

Looks like there's another problem in runtime/webgpu.cpp

[steven-johnson]

Funnily enough, this could not have caused a problem other than making a redundant check, which is why no tests failed, but that's only because GE has the same layout as GT.

Looks like there's another problem in runtime/webgpu.cpp

I did a clean CMake build and didn't get any warning there. Or did you find this by inspection?

[abadams]

I added the flag to the makefile build. Did adding the flag to cmake also cover the runtime?

[steven-johnson]

I added the flag to the makefile build. Did adding the flag to cmake also cover the runtime?

Nope, fixing now

[steven-johnson]

Please push your makefile fixes to this branch too