Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some EVAL_IN_LAMBDAs to Simplify_Sub.cpp #8230

Merged
merged 1 commit into from
May 23, 2024

Conversation

abadams
Copy link
Member

@abadams abadams commented May 22, 2024

Massively reduces compile time and peak cl.exe memory consumption on windows (from 9.5gb down to 2.3gb).

Simplify_LT.cpp has these same EVAL_IN_LAMBDAs, which is probably why it hasn't been causing build problems.

Massively reduces compile time and peak cl.exe memory consumption on
windows (from 9.5gb down to 2.3gb).

Simplify_LT.cpp has these same EVAL_IN_LAMBDAs, which is probably why it
hasn't been causing build problems.
@@ -184,7 +184,7 @@ Expr Simplify::visit(const Sub *op, ExprInfo *bounds) {
rewrite((slice(x, c0, c1, c2) - z) - slice(y, c0, c1, c2), slice(x - y, c0, c1, c2) - z, c2 > 1 && lanes_of(x) == lanes_of(y)) ||
rewrite((z - slice(x, c0, c1, c2)) - slice(y, c0, c1, c2), z - slice(x + y, c0, c1, c2), c2 > 1 && lanes_of(x) == lanes_of(y)) ||

(no_overflow(op->type) &&
(no_overflow(op->type) && EVAL_IN_LAMBDA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is only happening in MSVC, it might be worth only doing this #ifdef _MSC_VER?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also speeds up compile times for gcc slightly

@abadams abadams merged commit b5f5065 into main May 23, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants