-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect ARM CPU features for host target and in runtime #8298
Conversation
Not sure what the best way is to detect the ARMv8.1-A feature. It seems certain other features (e.g. sve/dotprod) imply it, or not (armv7s). |
Regarding the tutorial failures, lesson 15 uses the target string But with this PR, The fundamental issue is that "the host but on a different architecture" isn't a well-defined thing. Brainstorming a few possible resolutions:
|
Pending further discussion, I'm using this option to continue making progress:
|
Ready to land? |
No, the windows ARM code is still just a guess. We're trying to figure out how to test it. |
I'm trying to test it inside a Windows 11 ARM VM via UTM |
With the latest commit, I have Related to #2282 |
4bf13d6
to
90f5f6b
Compare
Review ping |
…elease/18.x) (#8343) Detect ARM CPU features for host target and in runtime (#8298) Adds feature detection for ARM CPUs to the runtime library and to the host target feature computation. Supports Windows, macOS, Linux, iOS, and Android. Also fix bug in Type::max() and Type::min() for float16. Fixes #4727 Fixes #6106 Fixes #7901 Fixes #7979 Fixes #8340 Co-authored-by: Alex Reinking <[email protected]>
Adds feature detection to the runtime library and to the
host
target feature computation.Not sure what the best way is to share code here. Not sure how best to test on Android or Windows/ARM, either.
Fixes #4727
Fixes #6106
Fixes #7901
Fixes #7979
Fixes #8340