This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
refactor: add validation for post and singlePage settings form #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
the
release-note
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
f2c-ci-robot
bot
added
the
kind/improvement
|
如果该问题在 2.0.x 中也存在，建议专门提交一个修复 bug 的 PR，并 patch 到 release-2.0 分支。 |
就是为了修改这个 bug 才这样修改。如果不重构来修复这个问题，改动可能会更大。 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
JohnNiang
pushed a commit
to JohnNiang/halo
that referenced
this pull request
Mar 2, 2023
…dev/console#791) #### What type of PR is this? /kind improvement #### What this PR does / why we need it: 重构文章和自定义页面的设置表单，支持提交时验证表单。 > 因为之前的多选项卡设计导致无法同时验证所有表单，所以这个 PR 重构了表单的布局。 #### Which issue(s) this PR fixes: Fixes halo-dev#2859 #### Screenshots:  #### Special notes for your reviewer: 测试方式： 1. 测试在内容编辑页面和列表打开文章和自定义页面的设置表单。 2. 检查表单验证是否有效。 #### Does this PR introduce a user-facing change? ```release-note 重构 Console 端文章和自定义页面的设置表单布局，支持提交时验证表单。 ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
What this PR does / why we need it:
重构文章和自定义页面的设置表单，支持提交时验证表单。
Which issue(s) this PR fixes:
Fixes halo-dev/halo#2859
Screenshots:
Special notes for your reviewer:
测试方式：
Does this PR introduce a user-facing change?