Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine pr.md to be clearer #77

Merged
merged 2 commits into from
Apr 25, 2022

Conversation

JohnNiang
Copy link
Member

@JohnNiang JohnNiang commented Apr 25, 2022

What this PR does

See halo-dev/halo#1890 for more.

Which issue this PR fix

Fix #76

/kind documentation
/cc @halo-dev/sig-docs

@f2c-ci-robot f2c-ci-robot bot added the kind/documentation Categorizes issue or PR as related to documentation. label Apr 25, 2022
@netlify
Copy link

netlify bot commented Apr 25, 2022

Deploy Preview for halo-docs ready!

Name Link
🔨 Latest commit c7cba3f
🔍 Latest deploy log https://app.netlify.com/sites/halo-docs/deploys/626617a36aac8b00084b7518
😎 Deploy Preview https://deploy-preview-77--halo-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2022
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Apr 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit e37e4e4 into halo-dev:main Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

同步 halo-dev/halo 的 CONTRIBUTING.md
3 participants