Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

修改主题升级的文案 #2857

Closed
ruibaby opened this issue Dec 6, 2022 · 4 comments · Fixed by halo-dev/console#747
Closed

修改主题升级的文案 #2857

ruibaby opened this issue Dec 6, 2022 · 4 comments · Fixed by halo-dev/console#747
Assignees
@Joydevelop
Labels
area/console Issues or PRs related to the Halo Console good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/improvement Categorizes issue or PR as related to a improvement.
Milestone
2.1.0

Comments

@ruibaby
Copy link
Member

ruibaby commented Dec 6, 2022

你当前使用的版本

2.0.0

描述一下此特性

当前主题弹出升级窗口的按钮文字为 更新，期望与插件（升级）保持一致。

image

image

插件：

image

/kind improvement
/area console

附加信息

No response
@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. area/console Issues or PRs related to the Halo Console labels Dec 6, 2022
@JohnNiang
Copy link
Member

/good-first-issue

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 6, 2022

@JohnNiang:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Dec 6, 2022
@Joydevelop
Copy link
Contributor

/assign

@Joydevelop Joydevelop mentioned this issue Dec 6, 2022
Merged
@JohnNiang
Copy link
Member

/milestone 2.1.x

@f2c-ci-robot f2c-ci-robot bot added this to the 2.1.x milestone Dec 6, 2022
f2c-ci-robot bot pushed a commit to halo-dev/console that referenced this issue Dec 6, 2022
@Joydevelop
perf: improve the text of the upgrade theme button (#747)
7bbad8b 
#### What type of PR is this?

/kind bug

#### What this PR does / why we need it:

修改主题升级文案

#### Which issue(s) this PR fixes:

Fixes halo-dev/halo#2857

#### Does this PR introduce a user-facing change?

```release-note
None
```
@JohnNiang JohnNiang modified the milestones: 2.1.x, 2.1.0 Dec 14, 2022
JohnNiang pushed a commit to JohnNiang/halo that referenced this issue Mar 2, 2023
@Joydevelop
perf: improve the text of the upgrade theme button (halo-dev/console#747
9d4e980 
)

#### What type of PR is this?

/kind bug

#### What this PR does / why we need it:

修改主题升级文案

#### Which issue(s) this PR fixes:

Fixes halo-dev#2857

#### Does this PR introduce a user-facing change?

```release-note
None
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Joydevelop Joydevelop

Labels
area/console Issues or PRs related to the Halo Console good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/improvement Categorizes issue or PR as related to a improvement.
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

perf: improve the text of the upgrade theme button Joydevelop/console
3 participants
@JohnNiang @ruibaby @Joydevelop