Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

希望halo2可以在新加菜单表单里加入菜单图标表单 #2878

Closed
daifiyum opened this issue Dec 7, 2022 · 7 comments
Closed

希望halo2可以在新加菜单表单里加入菜单图标表单 #2878

daifiyum opened this issue Dec 7, 2022 · 7 comments
Labels
area/console Issues or PRs related to the Halo Console kind/feature Categorizes issue or PR as related to a new feature.
Milestone
2.1.0

Comments

@daifiyum
Copy link

daifiyum commented Dec 7, 2022

你当前使用的版本

halo2.0

描述一下此特性

halo2.0新加菜单里没用菜单图标的输入框

附加信息

No response
@it985
Copy link

it985 commented Dec 7, 2022

+1 但是应该是主题的功能吧

@daifiyum
Copy link
Author

daifiyum commented Dec 7, 2022

+1 但是应该是主题的功能吧

主题的确可以通过一些手段实现但都不够优雅，例如我用新模板引擎提供的substringAfter()方法对标题截取特定字符来获得图标，但这种方式哪有在后台加入一个图标表单来的优雅？

@ruibaby
Copy link
Member

ruibaby commented Dec 7, 2022

@it985 @daifiyum 这个是计划要支持的，不过得等 #2858 完成。

@ruibaby
Copy link
Member

ruibaby commented Dec 7, 2022

/kind feature
/area console
/milestone 2.1.x

@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 7, 2022
@f2c-ci-robot f2c-ci-robot bot added this to the 2.1.x milestone Dec 7, 2022
@f2c-ci-robot f2c-ci-robot bot added the area/console Issues or PRs related to the Halo Console label Dec 7, 2022
@guqing guqing mentioned this issue Dec 26, 2022
Closed
@ruibaby
Copy link
Member

ruibaby commented Dec 28, 2022

目前 2.1.0-rc.1 已经支持为菜单项设置元数据表单，所以主题开发的时候如果需要在菜单支持显示图标，那么就可以定义一个 AnnotationSetting 模型。

具体文档可以关注：halo-dev/docs#154
定义方式可以参考：halo-dev/console#801 halo-dev/console#770

@ruibaby
Copy link
Member

ruibaby commented Dec 28, 2022

/close

@f2c-ci-robot f2c-ci-robot bot closed this as completed Dec 28, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 28, 2022

@ruibaby: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ruibaby ruibaby modified the milestones: 2.1.x, 2.1.0 Dec 28, 2022
@ruibaby ruibaby mentioned this issue Dec 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/console Issues or PRs related to the Halo Console kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

feat: add a default annotation setting for menu item guqing/halo
3 participants
@ruibaby @daifiyum @it985