Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wish the theme upgrade button could be more visible #2948

Closed
JohnNiang opened this issue Dec 14, 2022 · 2 comments · Fixed by halo-dev/console#774
Closed

Wish the theme upgrade button could be more visible #2948

JohnNiang opened this issue Dec 14, 2022 · 2 comments · Fixed by halo-dev/console#774
Assignees
@ruibaby
Labels
area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement.
Milestone
2.1.0

Comments

@JohnNiang
Copy link
Member

Your current Halo version

2.1.0-SNAPSHOT

Describe this feature

When I want to upgrade my theme, but it's not easy to find the upgrade button. Because the button is hidden here:

image

So, I wish the button could be more visible for end users.

Additional information

/kind improvement
/area console
@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. area/console Issues or PRs related to the Halo Console labels Dec 14, 2022
@ruibaby
Copy link
Member

ruibaby commented Dec 14, 2022

/milestone 2.1.x
/area console
/kind improvement
/assign

@f2c-ci-robot f2c-ci-robot bot added this to the 2.1.x milestone Dec 14, 2022
@ruibaby
Copy link
Member

ruibaby commented Dec 14, 2022

我将尝试优化升级、选择主题、激活主题的 UI 和逻辑。

@ruibaby ruibaby mentioned this issue Dec 15, 2022
Merged
f2c-ci-robot bot pushed a commit to halo-dev/console that referenced this issue Dec 16, 2022
@ruibaby
feat: add enable and upgrade support for theme list (#774)
6ac0816 
#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

1. 在主题管理列表添加启用和升级的支持。
2. 优化主题页面右上角的按钮布局
3. 优化主题管理的代码结构。

#### Which issue(s) this PR fixes:

Fixes halo-dev/halo#2948

#### Screenshots:

<img width="1515" alt="image" src="https://user-images.githubusercontent.com/21301288/207893631-6db10293-d0ee-4af4-9c43-f137055df28e.png">
<img width="1665" alt="image" src="https://user-images.githubusercontent.com/21301288/207894016-dd1a5d27-9fff-4211-8869-381208932eaf.png">


#### Special notes for your reviewer:

测试方式：

1. 进入主题管理，点击右上角的主题管理。
4. 测试单个主题的启用和升级是否符合预期。

#### Does this PR introduce a user-facing change?

```release-note
Console 端的主题管理列表添加启用和升级的支持。
```
@ruibaby ruibaby modified the milestones: 2.1.x, 2.1.0 Dec 19, 2022
JohnNiang pushed a commit to JohnNiang/halo that referenced this issue Mar 2, 2023
@ruibaby
feat: add enable and upgrade support for theme list (halo-dev/console…
c97c0ea 
…#774)

#### What type of PR is this?

/kind improvement

#### What this PR does / why we need it:

1. 在主题管理列表添加启用和升级的支持。
2. 优化主题页面右上角的按钮布局
3. 优化主题管理的代码结构。

#### Which issue(s) this PR fixes:

Fixes halo-dev#2948

#### Screenshots:

<img width="1515" alt="image" src="https://user-images.githubusercontent.com/21301288/207893631-6db10293-d0ee-4af4-9c43-f137055df28e.png">
<img width="1665" alt="image" src="https://user-images.githubusercontent.com/21301288/207894016-dd1a5d27-9fff-4211-8869-381208932eaf.png">


#### Special notes for your reviewer:

测试方式：

1. 进入主题管理，点击右上角的主题管理。
4. 测试单个主题的启用和升级是否符合预期。

#### Does this PR introduce a user-facing change?

```release-note
Console 端的主题管理列表添加启用和升级的支持。
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruibaby ruibaby

Labels
area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement.
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

feat: add enable and upgrade support for theme list ruibaby/halo-console
2 participants
@JohnNiang @ruibaby