Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

附件模块中新建存储策略或者分组应该不存在重复相同的分组或者存储策略 #6946

Closed
LEIYOUSU opened this issue Oct 25, 2024 · 5 comments · Fixed by #6959
Closed

附件模块中新建存储策略或者分组应该不存在重复相同的分组或者存储策略 #6946

LEIYOUSU opened this issue Oct 25, 2024 · 5 comments · Fixed by #6959
Assignees
@LEIYOUSU
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/improvement Categorizes issue or PR as related to a improvement.

Comments

@LEIYOUSU
Copy link
Contributor

System information

What is the project operation method?

Docker

What happened?

下图显示为重复创建了两个相同的分组“111”以及相同的存储策略“ces”。个人认为，当重复建组的时候应该提示:该分组已存在，实现不重名机制
Image
Image

Reproduce Steps

No response

Relevant log output

No response

Additional information

No response
@ruibaby
Copy link
Member

ruibaby commented Oct 26, 2024

可以考虑进行优化，@guqing 是否可以对 Group 的 displayName 添加唯一索引来限制？我的理解是，如果现在添加，以前如果有同名话，可能会创建索引失败，那么就只能在前端创建时查询一次来限制添加重名的分组。

/kind improvement
/good-first-issue

@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 26, 2024

@ruibaby:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

可以考虑进行优化，@guqing 是否可以对 Group 的 displayName 添加唯一索引来限制？我的理解是，如果现在添加，以前如果有同名话，可能会创建索引失败，那么就只能在前端创建时查询一次来限制添加重名的分组。

/kind improvement
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Oct 26, 2024
@guqing
Copy link
Member

guqing commented Oct 26, 2024

可以考虑进行优化，@guqing 是否可以对 Group 的 displayName 添加唯一索引来限制？我的理解是，如果现在添加，以前如果有同名话，可能会创建索引失败，那么就只能在前端创建时查询一次来限制添加重名的分组。

/kind improvement
/good-first-issue

目前最好是在前端创建时校验一下 加唯一索引可能会导致有些用户无法使用

@LEIYOUSU
Copy link
Contributor Author

我想认领这个 issue，我会尽快处理。谢谢！

@ruibaby
Copy link
Member

ruibaby commented Oct 28, 2024

/assign @LEIYOUSU

@LEIYOUSU LEIYOUSU mentioned this issue Oct 28, 2024
Merged
@f2c-ci-robot f2c-ci-robot bot closed this as completed in 77548ec Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LEIYOUSU LEIYOUSU

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/improvement Categorizes issue or PR as related to a improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add name existence check before creating attachment group and storage policy LEIYOUSU/halo
3 participants
@ruibaby @guqing @LEIYOUSU