Fix the problem jsonToCacheWrapper crashes when cache value is not JSON format #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guqing
changed the title
guqing
changed the title
ruibaby
approved these changes
Mar 2, 2022
ruibaby
approved these changes
Mar 2, 2022
JohnNiang
changed the title
winar-jin
pushed a commit
to winar-jin/halo
that referenced
this pull request
Mar 24, 2022
…ON format (halo-dev#1695) * fix: json to cache wrapper convertor when other exception * feat: Add test case for level cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does?
对
jsonToCacheWrapper(String json)方法捕获的异常放宽为Exception,也就是一旦转换出错就不放入缓存，否则出现未处理异常时会导致功能无法使用Why we need it?
Fix #1681, #1683
但没有完全解决 #1683 问题，所以不应该关联关闭它