Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem of duplicate path separator in windows system #1812

Merged
merged 2 commits into from
Apr 2, 2022

Conversation

guqing
Copy link
Member

@guqing guqing commented Apr 2, 2022

What this PR does?

as the title described.

Why we need it?

Fix #1800

/cc @halo-dev/sig-halo
/kind bug
/area core

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. area/core Issues or PRs related to the Halo Core labels Apr 2, 2022
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Apr 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit 1de5799 into halo-dev:master Apr 2, 2022
@ruibaby ruibaby added this to the 1.5.x milestone Apr 2, 2022
@guqing guqing deleted the bugfix/1800 branch April 2, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.4.5 升级 1.5.0 图片本地上创 markdown 链接问题
2 participants