Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

temporarily stop database connection while backing up database files #1867

Merged
merged 4 commits into from
Apr 22, 2022
Merged

temporarily stop database connection while backing up database files #1867

merged 4 commits into from
Apr 22, 2022

Conversation

anshangPro
Copy link

@anshangPro anshangPro commented Apr 20, 2022 •
edited
Loading

What this PR does?

fix #1866

  • When backing up, temporarily stop HikariPool.

@CLAassistant
Copy link

CLAassistant commented Apr 20, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@anshangPro
Copy link
Author

Limit the scope of modification to only the Windows system and h2 database.

JohnNiang
JohnNiang reviewed Apr 21, 2022
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @anshangPro ，我这里有两个小小的提议，有时间了请看看。

src/main/java/run/halo/app/service/impl/BackupServiceImpl.java Outdated Show resolved Hide resolved
src/main/java/run/halo/app/service/impl/BackupServiceImpl.java Outdated Show resolved Hide resolved
ruibaby
ruibaby reviewed Apr 21, 2022
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2022
JohnNiang
JohnNiang reviewed Apr 22, 2022
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it manually, and it works very well in Windows. Thank @anshangPro for the contribution!

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Apr 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2022
@f2c-ci-robot f2c-ci-robot bot merged commit de28811 into halo-dev:master Apr 22, 2022
@JohnNiang
Copy link
Member

/cherrypick release-1.5

@halo-dev-bot halo-dev-bot mentioned this pull request Apr 28, 2022
Merged
@halo-dev-bot
Copy link
Collaborator

@JohnNiang: new pull request created: #1901

In response to this:

/cherrypick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruibaby ruibaby ruibaby left review comments

@JohnNiang JohnNiang JohnNiang left review comments

@lan-yonghui lan-yonghui Awaiting requested review from lan-yonghui

Assignees

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

备份过程出现IOException
5 participants
@anshangPro @CLAassistant @JohnNiang @halo-dev-bot @ruibaby