Catch up with LedgerHQ fork #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vendor/base58: remove unused headers.
Partial revert of 0348991 This was causing a segfault in strcpy() in line 1212
Too many of these to see more relevant warnings in the compiler output!
When we call ledger_apdu_cache_flush() we may end up combining some leftover data from the cache with a full 255-byte packet from the APDU buffer. We must use uint16 for the length counter or it will roll over.
Update for Nano X UX_FLOW and Nano S SDK 1612
convert nanos icon to nanox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains commits that:
handshake-org/s-x-compactinto master (LedgerHQ has already done this in v1.0.4It leaves out one commit (the latest one) from LedgerHQ that adds a GitHub PR template specific to their processes.
Next steps:
1.0.4,1.0.5) tohandshake-orgs-x-compactbranch to avoid confusionnanoxbranch since those commits are already on master before 1.0.3 was tagged