[WIP] Hapi 17 Support #332
Conversation
ChristianMurphy
force-pushed
the
hapi-17
branch
2 times, most recently
from
2824293
to
d2e4967
Compare
| @@ -1,21 +1,15 @@ | |||
| language: node_js | |||
|
|
|||
| node_js: | |||
| - "4" | |||
| - "6" | |||
API.md
Outdated
| var server = new Hapi.Server(); | ||
|
|
||
| server.connection({ port: 8000 }); | ||
| var server = new Hapi.Server({ port: 8000 }); |
There was a problem hiding this comment.
Hapi 17 doesn't need a new.
package.json
Outdated
| }, | ||
| "scripts": { | ||
| "test": "node node_modules/lab/bin/lab -t 100 -L -v", | ||
| "test-cov-html": "node node_modules/lab/bin/lab -r html -o coverage.html -L" | ||
| "test": "lab -t 100 -L -v", |
There was a problem hiding this comment.
Should probably add back -a code to both since lab is back to no default assertion library.
| var server = new Hapi.Server(); | ||
|
|
||
| server.connection({ port: 8000 }); | ||
| var { Server } = require('hapi'); |
There was a problem hiding this comment.
Might as well use consts and other ES6 features wherever possible now.
There was a problem hiding this comment.
Updated to const
Will be leveraging more ES6 features in the next few refactors.
ldesplat
added
breaking changes
|
I mistakenly pushed to your branch but I forced it back to what it was :) This hapi 17 upgrade is very non trivial for bell and all its tests. |
ChristianMurphy
force-pushed
the
hapi-17
branch
from
79dcee4
to
130368d
Compare
|
Closing, in favor of #334 |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
TODO:
asyncandawaitresolves #330