feat: target ESLint v9 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marsup
force-pushed
the
feat/target-eslint-9
branch
from
0d9adf6
to
fa4ab06
Compare
|
The new version 7.0.0 seems to break tests, eg. here hapijs/bounce#38. |
|
I know, it's because it's not supposed to be used with lab 25, but we put "*" out of laziness. Sadly, it's the case for many of our packages, I've updated bounce, you can rebase your branches, I'll update all the other packages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes all rules and configs work with ESLint v9. I have not tried to keep it compatible with v8 as I'm not sure it's worth the effort. Some code (the rules) was automatically migrated by an eslint tool and is probably compatible with both versions though, so if we decide to keep backwards-compatibility, we probably just have to keep a duplicate of the old configs. As can be seen in lab's PR, I'm not sure how to properly handle the old .eslintignore behavior, so I went with passing it through labrc.
The CI will of course fail as it needs a compatible lab to work.