Extend Hapi cli to enable loading a module before loading hapi #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var extras = internals.argv.require; | ||
|
|
||
| if (!extras) { | ||
|
|
|
removed |
|
@wpreul do you have travis rebuild option on this, I can't seem to find it if it is available to me... |
|
Tried a rebuild... no luck... can you repro locally? |
|
There we go :) |
hueniverse
pushed a commit
that referenced
this pull request
May 18, 2014
Extend Hapi cli to enable loading a module before loading hapi
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for adding is to allow the loading of a metrics modules such as newrelic before anything else critical, this could also be useful for other metrics gathering modules as well.