Idn support #6
Idn support #6
Conversation
Not ready yet - need to provide the punycode if the domain is utf8
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
==========================================
+ Coverage 84.81% 85.88% +1.07%
==========================================
Files 1 2 +1
Lines 79 85 +6
Branches 16 17 +1
==========================================
+ Hits 67 73 +6
Misses 12 12
Continue to review full report at Codecov.
|
TODO
|
|
FWIW punycode is core node.js
…On Mon, May 22, 2017 at 7:41 PM, Matt Simerson ***@***.***> wrote:
TODO
- add punycode as package dependency
- bump version in package.json
- update Changes.md
- publish to npm
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAobY-e4nGjYB9zoTr9ukMNmpkS_-kFiks5r8h0hgaJpZM4Ni_1R>
.
|
|
https://nodejs.org/api/punycode.html "The version of the punycode module bundled in Node.js is being deprecated. In a future major version of Node.js this module will be removed. Users currently depending on the punycode module should switch to using the userland-provided Punycode.js module instead." (We already explicitly depend on the npm packaged version of punycode in haraka-tld). |
|
Didn't know that. Fair enough.
|
|
What typo? |
|
To find the typo, search for |
|
Regarding punycode, I included punycode.js in Nodemailer for a while but stopped doing that pretty fast and kept using the deprecated native module:
So what happened in my case was that people started to complain about the warnings when installing Nodemailer even though the module that caused the warnings wasn't actually even used. Regarding RFC6531, do you intend to use the SMTPUTF8 keyword for MAIL FROM somehow or do you just silently ignore it? If it is just ignored then I guess it doesn't really matter though. |
|
We'll just ignore the keyword. @msimerson what do you think about the npm module issue? |
Punycode was deprecated in v7 and is expected to be removed in node v8. I'd much rather add the explicit dependency and so we're future-ready than worry about users of node v4 getting a module warning. Users getting this newer version of Haraka and module will be mostly new installs and most distros are already bundling node v6 or v7. I suspect warnings on node v4 will be few and will tail off to zero over the next 10 months when node v4 is EOL. |
|
OK. This should be ready to merge and release now.
…On Thu, May 25, 2017 at 1:13 PM, Matt Simerson ***@***.***> wrote:
what do you think about the npm module issue?
Punycode was deprecated in v7 and is expected to be removed in node v8.
I'd much rather add the explicit dependency and so we're future-ready than
worry about users of node v4 getting a module warning. Users getting this
newer version of Haraka and module will be mostly new installs and most
distros are already bundling node v6 or v7. I suspect warnings on node v4
will be few and will tail off to zero over the next 10 months when node v4
is EOL.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAobYx_99b3HqkI6uQfrVTF2SNRhXeC8ks5r9bangaJpZM4Ni_1R>
.
|
|
Also, there's a conversation regarding punycode over at nodejs/node#7552. As of node 7.4 there's experimental |
|
I'm having trouble publishing this - it seems to be published by "haraka" but not one of @haraka the group's npm modules: https://www.npmjs.com/org/haraka Do we need to email npm support? |
|
Unfortunately, @haraka (groups) don't work the way you'd expect on NPM. I just manually added your and Steve's npm ids to this module. |
|
I think you'd be able to had you tried again but I just published this. |
Should facilitate SMTPUTF8 support in Haraka