Backport gcc-7 compilation fix from mainline linux tree #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original commit: 474c901 Author: Linus Torvalds <[email protected]> Summary: give up on gcc ilog2() constant optimizations
mdrjr
approved these changes
Jun 26, 2017
|
Could we maybe get this merged, because currently compiling the odroid-3.14.y branch with gcc 7.x breaks hw accelleration on the Odroid C2 as can be seen here. |
|
Does recompiling with gcc7 and this patch actually help (as opposed to no-patch or gcc6)? I'm a bit skeptical, because it's a fix for build error, which afaict affects only aufs module, so if you can build with up-to-date gcc7, doesn't seem to be relevant to your issue and maybe not needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit: 474c901
Author: Linus Torvalds [email protected]
Summary: give up on gcc ilog2() constant optimizations
This fixes build issue with gcc-7.
How failure looks: https://sourceforge.net/p/aufs/mailman/message/35865397/
Issue in kernel bugzilla: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=72785
Link to commit addressing it in mainline: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/patch/?id=474c90156c8dcc2fa815e6716cc9394d7930cb9c