Fixes conductor-oss#7, another dormant bug

haricane8133 · Jan 2, 2024 · 32d7be4 · 32d7be4
1 parent fec3116
commit 32d7be4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/ui/src/components/NavLink.jsx b/ui/src/components/NavLink.jsx
@@ -26,7 +26,8 @@ export default React.forwardRef((props, ref) => {
       </Link>
     );
   } else {
-    const href = absolutePath ? url.toString() : cleanDuplicateSlash(getBasename() + url.toString());
+    // Note: + '/' + is required here
+    const href = absolutePath ? url.toString() : cleanDuplicateSlash(getBasename() + '/' + url.toString());
     return (
       <Link ref={ref} target="_blank" href={href}>
         {rest.children}

diff --git a/ui/src/plugins/fetch.js b/ui/src/plugins/fetch.js
@@ -41,6 +41,12 @@ export function fetchWithContext(
     });
 }
 
+/**
+ * @param {string} path 
+ * @returns path with '/' not duplicated except at ://
+ * 
+ * Note: we need the second .replace() because the first one doesn't catch multiple slashes at the start of the string
+ */
 export function cleanDuplicateSlash(path) {
-  return path.replace(/([^:]\/)\/+/g, "$1");
+  return path.replace(/([^:]\/)\/+/g, "$1").replace(/^(\/)+/, '/');
 }