Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depends django-pymemcache #103

Merged
merged 3 commits into from
Jun 29, 2020
Merged

Depends django-pymemcache #103

merged 3 commits into from
Jun 29, 2020
+145 −123

Conversation

Surgo
Copy link

@Surgo Surgo commented Jun 29, 2020 •
edited
Loading

  • Use django-pymemcache's client
  • Support all methods

@Surgo Surgo added this to the 2.0.0 milestone Jun 29, 2020
@Surgo Surgo self-assigned this Jun 29, 2020
Surgo
Surgo commented Jun 29, 2020
View reviewed changes
django_elastipymemcache/memcached.py
from django.core.cache import InvalidCacheBackendError
from django.core.cache.backends.memcached import BaseMemcachedCache

from . import client as pymemcache_client
from djpymemcache import client as djpymemcache_client
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As same as https://github.com/django-pymemcache/django-pymemcache/blob/master/djpymemcache/client.py

Surgo
Surgo commented Jun 29, 2020
View reviewed changes
django_elastipymemcache/memcached.py
@invalidate_cache_after_error
def delete(self, *args, **kwargs):
return super().delete(*args, **kwargs)

@invalidate_cache_after_error
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support all methods

@codecov
Copy link

codecov bot commented Jun 29, 2020 •
edited
Loading

Codecov Report

Merging #103 into master will increase coverage by 2.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
+ Coverage   95.20%   97.29%   +2.09%     
==========================================
  Files           4        3       -1     
  Lines         125      111      -14     
  Branches       13        9       -4     
==========================================
- Hits          119      108      -11     
+ Misses          2        1       -1     
+ Partials        4        2       -2
Impacted Files Coverage Δ
django_elastipymemcache/cluster_utils.py 94.87% <100.00%> (+5.12%) ⬆️
django_elastipymemcache/memcached.py 98.57% <100.00%> (+1.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fefcd0...9a8e6e6. Read the comment docs.

@heavenshell heavenshell merged commit 7d5360c into master Jun 29, 2020
@heavenshell heavenshell deleted the topic/depends_django_pymemcache branch June 29, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heavenshell heavenshell heavenshell approved these changes

Assignees

@Surgo Surgo

Labels
enhancement
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Surgo @heavenshell