Deal with server not ready gracefully #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49
We've also observed this situation sometimes.
This implements a simple solution, the response is still an error so prometheus should handle it as such, but an exception doesn't bubble up in the app.
I haven't been able to find a way to query any public interface offered by puma to identify the situation, so I'm capturing the exception.
Testing is not straightforward since it depends on timing. One way to do it is to insert a
sleep 10
here:https://github.com/puma/puma/blob/8e7fab5f3992ef056dd9030a89da0372f933e5d4/lib/puma/single.rb#L51
With that, if we make a metrics request right after the app starts we see this code in action:
After 10 seconds requests return the regular prometheus payload: