Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FFM-11846] : Store and delete previous version of the FeatureConfig along with the new one in cache #194

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

akiraqb
Copy link
Contributor

@akiraqb akiraqb commented Aug 6, 2024

[FFM-11846] : Store and delete previous version of the FeatureConfig along with the new one.
 ### What: 
Store and retrieve current and previous version of the feature config.
Delete both versions of the config.
Added tests
 ### Why:
To meet customer's requirements.
 ### Testing:
Locally + unit tests

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@akiraqb akiraqb changed the title [FFM-11846] : Store and delete previous version of the FeatureConfig along with the new one [FFM-11846] : Store and delete previous version of the FeatureConfig along with the new one in cache Aug 7, 2024
@akiraqb akiraqb changed the base branch from main to FFM-11844 August 7, 2024 12:16
@erdirowlands erdirowlands self-requested a review August 7, 2024 13:05
Copy link
Contributor

@erdirowlands erdirowlands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This good good. Just one query which may be a non-issue.

@akiraqb akiraqb marked this pull request as ready for review August 7, 2024 13:55
@akiraqb akiraqb merged commit 433886e into FFM-11844 Aug 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants