Fixed swagger errors. Remove envelope Id from the description #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshitav-docusign
requested review from
sriharip-docusign and
angelga-docusign
angelga-docusign
approved these changes
Oct 23, 2023
harshitav-docusign
added a commit
that referenced
this pull request
Oct 30, 2023
* FLOW-282: Add unique tab label for all tab types * FLOW-294: Replace the dropdown for update ecf by text and deprecate v2 version of create from template action * The 'summary' value goes over the character limit '80'. Shortened it. * FLOW-292: witness "name" should not be displayed as a required field * Don't show V2 in the deprecated version of create envelope using template * FLOW-271: Power Automate: Unable to turn off and turn back on, a flow, that uses connect trigger * Adding delete hook for v3 trigger * FLOW-312 - Value property needs to be part the output field in Get envelope custom field action * FLOW-338: template prefill : in create from template action , add support for email subject and body * UI is added * Phone and SMS recipients added to the solution * Add all the signer properties to the output * Add + to the trip character array * Indendation fixed * Implement feedback * FLOW-343: update recipient action * support SMS delivery * support all recipient types * remove the extra forward slash * Implemented GetRecipientFields for all the recipient types * Remove signers array * Remove double referencing. Add signer object to an array * remove the extra blank line * FLOW-345: DocGen: Get document id given a document name * Code optimization implemented * UI of the GetTabValues * Lower case the labels * Updated the custom action title * Updated the operationId * Fix bug around no-match found * Convert token to string before matching * Get Tab Info method implementation added * Validation added to check if tab label provided is missing * UI is added. Script needs little work * Removed the string conversion tabLabel * able to output 1 tab * FLOW-348: List Templates Action for Power Automate Expose it , so that Microsoft's maker / c2 experience can leverage. * Fix the meal db connector issue * no message * Working code generating output. The body data needs to be added * Document details are returned * FLOW-377: c2: Sender/Signer can create an envelope from a template using a variable for the template ID * Add validation message * Rewrite request url for /envelopes/createFromTemplateNoRecipients endpoint * Operation Id updated * Add the shortform to create array of objects * Get template documents action added * Updated the description * Removed the x-ms-visibility property * fixed the indendation * FLOW-374: c2 get document tabs from envelope * Update the schema for Tab with additional properties * Recipient tabs test case added * Add validation statement * Removing the duplicate code * UI fix * Get template document tabs added * ListEnvelopeDocumentFields custom action added * Update UI * FLOW-365: c2: update envelope prefill tabs * Rename field identifier to match the internal names * Fix description grammar * Add a field to indicate whether a tab is prefill or not for the get action * UI added * FLOW-346: DocGen - Get merge fields * UpdateRecipientTabs added * Removed StaticResponse * REmoved StaticResponseForTabTypesWithValues * Remove the ms-visibility * FLOW-347: DocGen: Update merge fields * Add a check if the email token exists in the signer objects * Optimize the if statement * Bump the build number for C2/R2 release * Add back the removed Meal DB/Readme.md file * FLOW-392: Get document id action should return both id and guid * Expose template id in the output of create envelope using template actions * Add GetEnvelopeDocumentFields custom method * Added delivery phone and SMS phone options * formating the code * convert template input to a template dropdown * Rename actions to make it more readable for the user * Update doc gen action name * identiti verification added * Fix typo in "List documents from an envelope" action name * DS1002 R2 and C2 Release for DocuSign Connector Porting changes from DocuSign Demo -> DocuSign Connector * FLOW-427: Support "Transform PDF fields to DocuSign tabs" in Power Automate * Sales copilot custom actions are added (cherry picked from commit 90c0601) * Update title with lower case (cherry picked from commit 9b6111c) * Release candidate DS1003 created * Build number updated * Transfering DocuSign demo code to DocuSign prod connector * Porting changes from DocuSign demo dev to MSFlow.DS1003.10.17.2023 * Fix the title and description specific to Prod * Build number updated * cherry pick the swagger fixes to the release branchemoved envelopeId and swagger validation errors fixed:ge pull request #38 from harshitav-docusign/swagger_updates Fixed swagger errors. Remove envelope Id from the description * swagger validation errors fixed. EnvelopeId removed * Resolved conflicts * NLP changes added * Validated with paconn tool --------- Co-authored-by: Srihari Padmanabhan <[email protected]> Co-authored-by: Srihari Padmanabhan <[email protected]> Co-authored-by: Angel Garcia Reyes <[email protected]> Co-authored-by: Mahbub Murshed <[email protected]>
harshitav-docusign
added a commit
that referenced
this pull request
Nov 7, 2023
* The 'summary' value goes over the character limit '80'. Shortened it. * FLOW-292: witness "name" should not be displayed as a required field * Don't show V2 in the deprecated version of create envelope using template * FLOW-271: Power Automate: Unable to turn off and turn back on, a flow, that uses connect trigger * Adding delete hook for v3 trigger * FLOW-312 - Value property needs to be part the output field in Get envelope custom field action * FLOW-338: template prefill : in create from template action , add support for email subject and body * UI is added * Phone and SMS recipients added to the solution * Add all the signer properties to the output * Add + to the trip character array * Indendation fixed * Implement feedback * FLOW-343: update recipient action * support SMS delivery * support all recipient types * remove the extra forward slash * Implemented GetRecipientFields for all the recipient types * Remove signers array * Remove double referencing. Add signer object to an array * remove the extra blank line * FLOW-345: DocGen: Get document id given a document name * Code optimization implemented * UI of the GetTabValues * Lower case the labels * Updated the custom action title * Updated the operationId * Fix bug around no-match found * Convert token to string before matching * Get Tab Info method implementation added * Validation added to check if tab label provided is missing * UI is added. Script needs little work * Removed the string conversion tabLabel * able to output 1 tab * FLOW-348: List Templates Action for Power Automate Expose it , so that Microsoft's maker / c2 experience can leverage. * Fix the meal db connector issue * no message * Working code generating output. The body data needs to be added * Document details are returned * FLOW-377: c2: Sender/Signer can create an envelope from a template using a variable for the template ID * Add validation message * Rewrite request url for /envelopes/createFromTemplateNoRecipients endpoint * Operation Id updated * Add the shortform to create array of objects * Get template documents action added * Updated the description * Removed the x-ms-visibility property * fixed the indendation * FLOW-374: c2 get document tabs from envelope * Update the schema for Tab with additional properties * Recipient tabs test case added * Add validation statement * Removing the duplicate code * UI fix * Get template document tabs added * ListEnvelopeDocumentFields custom action added * Update UI * FLOW-365: c2: update envelope prefill tabs * Rename field identifier to match the internal names * Fix description grammar * Add a field to indicate whether a tab is prefill or not for the get action * UI added * FLOW-346: DocGen - Get merge fields * UpdateRecipientTabs added * Removed StaticResponse * REmoved StaticResponseForTabTypesWithValues * Remove the ms-visibility * FLOW-347: DocGen: Update merge fields * Add a check if the email token exists in the signer objects * Optimize the if statement * Bump the build number for C2/R2 release * Add back the removed Meal DB/Readme.md file * FLOW-392: Get document id action should return both id and guid * Expose template id in the output of create envelope using template actions * Add GetEnvelopeDocumentFields custom method * Added delivery phone and SMS phone options * formating the code * convert template input to a template dropdown * Rename actions to make it more readable for the user * Update doc gen action name * identiti verification added * Fix typo in "List documents from an envelope" action name * DS1002 R2 and C2 Release for DocuSign Connector Porting changes from DocuSign Demo -> DocuSign Connector * FLOW-427: Support "Transform PDF fields to DocuSign tabs" in Power Automate * Sales copilot custom actions are added (cherry picked from commit 90c0601) * Update title with lower case (cherry picked from commit 9b6111c) * Release candidate DS1003 created * Build number updated * cherry picking from harshita devMerge pull request #37 from harshitav-docusign/BugBashFixes SalesCopilot: Recipient names as array. Status to TitleCase. DocumentNLP formatting * Merged bug fixesMerge pull request #36 from harshitav-docusign/recordId_issue RecordId and OrgUrl filters fixed. Activities and Records render latest first * Merge pull request #37 from harshitav-docusign/BugBashFixes SalesCopilot: Recipient names as array. Status to TitleCase. DocumentNLP formatting * Adding back PPDF tranformation fields * Fix spacing issues * Transfering DocuSign demo code to DocuSign prod connector * Porting changes from DocuSign demo dev to MSFlow.DS1003.10.17.2023 * Fix the title and description specific to Prod * Corrected the swagger. Removed envelopeId from responseMerge pull request #38 from harshitav-docusign/swagger_updates Fixed swagger errors. Remove envelope Id from the description * removed merge conflicts * Additional properties fixed. DateTime formatted * Added local time and additional properties * rearranged the swagger definition --------- Co-authored-by: Srihari Padmanabhan <[email protected]> Co-authored-by: Srihari Padmanabhan <[email protected]> Co-authored-by: Angel Garcia Reyes <[email protected]> Co-authored-by: Mahbub Murshed <[email protected]>
harshitav-docusign
added a commit
that referenced
this pull request
Mar 15, 2024
…oft#3293) * FLOW-292: witness "name" should not be displayed as a required field * Don't show V2 in the deprecated version of create envelope using template * FLOW-271: Power Automate: Unable to turn off and turn back on, a flow, that uses connect trigger * Adding delete hook for v3 trigger * FLOW-312 - Value property needs to be part the output field in Get envelope custom field action * FLOW-338: template prefill : in create from template action , add support for email subject and body * UI is added * Phone and SMS recipients added to the solution * Add all the signer properties to the output * Add + to the trip character array * Indendation fixed * Implement feedback * FLOW-343: update recipient action * support SMS delivery * support all recipient types * remove the extra forward slash * Implemented GetRecipientFields for all the recipient types * Remove signers array * Remove double referencing. Add signer object to an array * remove the extra blank line * FLOW-345: DocGen: Get document id given a document name * Code optimization implemented * UI of the GetTabValues * Lower case the labels * Updated the custom action title * Updated the operationId * Fix bug around no-match found * Convert token to string before matching * Get Tab Info method implementation added * Validation added to check if tab label provided is missing * UI is added. Script needs little work * Removed the string conversion tabLabel * able to output 1 tab * FLOW-348: List Templates Action for Power Automate Expose it , so that Microsoft's maker / c2 experience can leverage. * Fix the meal db connector issue * no message * Working code generating output. The body data needs to be added * Document details are returned * FLOW-377: c2: Sender/Signer can create an envelope from a template using a variable for the template ID * Add validation message * Rewrite request url for /envelopes/createFromTemplateNoRecipients endpoint * Operation Id updated * Add the shortform to create array of objects * Get template documents action added * Updated the description * Removed the x-ms-visibility property * fixed the indendation * FLOW-374: c2 get document tabs from envelope * Update the schema for Tab with additional properties * Recipient tabs test case added * Add validation statement * Removing the duplicate code * UI fix * Get template document tabs added * ListEnvelopeDocumentFields custom action added * Update UI * FLOW-365: c2: update envelope prefill tabs * Rename field identifier to match the internal names * Fix description grammar * Add a field to indicate whether a tab is prefill or not for the get action * UI added * FLOW-346: DocGen - Get merge fields * UpdateRecipientTabs added * Removed StaticResponse * REmoved StaticResponseForTabTypesWithValues * Remove the ms-visibility * FLOW-347: DocGen: Update merge fields * Add a check if the email token exists in the signer objects * Optimize the if statement * Bump the build number for C2/R2 release * Add back the removed Meal DB/Readme.md file * FLOW-392: Get document id action should return both id and guid * Expose template id in the output of create envelope using template actions * Add GetEnvelopeDocumentFields custom method * Added delivery phone and SMS phone options * formating the code * convert template input to a template dropdown * Rename actions to make it more readable for the user * Update doc gen action name * identiti verification added * Fix typo in "List documents from an envelope" action name * DS1002 R2 and C2 Release for DocuSign Connector Porting changes from DocuSign Demo -> DocuSign Connector * FLOW-427: Support "Transform PDF fields to DocuSign tabs" in Power Automate * Sales copilot custom actions are added (cherry picked from commit 90c0601) * Update title with lower case (cherry picked from commit 9b6111c) * Release candidate DS1003 created * Build number updated * cherry picking from harshita devMerge pull request #37 from harshitav-docusign/BugBashFixes SalesCopilot: Recipient names as array. Status to TitleCase. DocumentNLP formatting * Merged bug fixesMerge pull request #36 from harshitav-docusign/recordId_issue RecordId and OrgUrl filters fixed. Activities and Records render latest first * Merge pull request #37 from harshitav-docusign/BugBashFixes SalesCopilot: Recipient names as array. Status to TitleCase. DocumentNLP formatting * Adding back PPDF tranformation fields * Fix spacing issues * Transfering DocuSign demo code to DocuSign prod connector * Porting changes from DocuSign demo dev to MSFlow.DS1003.10.17.2023 * Fix the title and description specific to Prod * Corrected the swagger. Removed envelopeId from responseMerge pull request #38 from harshitav-docusign/swagger_updates Fixed swagger errors. Remove envelope Id from the description * removed merge conflicts * Additional properties fixed. DateTime formatted * Added local time and additional properties * Remove the Max payload exceed messaging * Remove changes in the DocuSign folder --------- Co-authored-by: Srihari Padmanabhan <[email protected]> Co-authored-by: Srihari Padmanabhan <[email protected]> Co-authored-by: Angel Garcia Reyes <[email protected]> Co-authored-by: Mahbub Murshed <[email protected]>
harshitav-docusign
added a commit
that referenced
this pull request
Mar 15, 2024
* FLOW-271: Power Automate: Unable to turn off and turn back on, a flow, that uses connect trigger * Adding delete hook for v3 trigger * FLOW-312 - Value property needs to be part the output field in Get envelope custom field action * FLOW-338: template prefill : in create from template action , add support for email subject and body * UI is added * Phone and SMS recipients added to the solution * Add all the signer properties to the output * Add + to the trip character array * Indendation fixed * Implement feedback * FLOW-343: update recipient action * support SMS delivery * support all recipient types * remove the extra forward slash * Implemented GetRecipientFields for all the recipient types * Remove signers array * Remove double referencing. Add signer object to an array * remove the extra blank line * FLOW-345: DocGen: Get document id given a document name * Code optimization implemented * UI of the GetTabValues * Lower case the labels * Updated the custom action title * Updated the operationId * Fix bug around no-match found * Convert token to string before matching * Get Tab Info method implementation added * Validation added to check if tab label provided is missing * UI is added. Script needs little work * Removed the string conversion tabLabel * able to output 1 tab * FLOW-348: List Templates Action for Power Automate Expose it , so that Microsoft's maker / c2 experience can leverage. * Fix the meal db connector issue * no message * Working code generating output. The body data needs to be added * Document details are returned * FLOW-377: c2: Sender/Signer can create an envelope from a template using a variable for the template ID * Add validation message * Rewrite request url for /envelopes/createFromTemplateNoRecipients endpoint * Operation Id updated * Add the shortform to create array of objects * Get template documents action added * Updated the description * Removed the x-ms-visibility property * fixed the indendation * FLOW-374: c2 get document tabs from envelope * Update the schema for Tab with additional properties * Recipient tabs test case added * Add validation statement * Removing the duplicate code * UI fix * Get template document tabs added * ListEnvelopeDocumentFields custom action added * Update UI * FLOW-365: c2: update envelope prefill tabs * Rename field identifier to match the internal names * Fix description grammar * Add a field to indicate whether a tab is prefill or not for the get action * UI added * FLOW-346: DocGen - Get merge fields * UpdateRecipientTabs added * Removed StaticResponse * REmoved StaticResponseForTabTypesWithValues * Remove the ms-visibility * FLOW-347: DocGen: Update merge fields * Add a check if the email token exists in the signer objects * Optimize the if statement * Bump the build number for C2/R2 release * Add back the removed Meal DB/Readme.md file * FLOW-392: Get document id action should return both id and guid * Expose template id in the output of create envelope using template actions * Add GetEnvelopeDocumentFields custom method * Added delivery phone and SMS phone options * formating the code * convert template input to a template dropdown * Rename actions to make it more readable for the user * Update doc gen action name * identiti verification added * Fix typo in "List documents from an envelope" action name * DS1002 R2 and C2 Release for DocuSign Connector Porting changes from DocuSign Demo -> DocuSign Connector * FLOW-427: Support "Transform PDF fields to DocuSign tabs" in Power Automate * Sales copilot custom actions are added (cherry picked from commit 90c0601) * Update title with lower case (cherry picked from commit 9b6111c) * Release candidate DS1003 created * Build number updated * cherry picking from harshita devMerge pull request #37 from harshitav-docusign/BugBashFixes SalesCopilot: Recipient names as array. Status to TitleCase. DocumentNLP formatting * Merged bug fixesMerge pull request #36 from harshitav-docusign/recordId_issue RecordId and OrgUrl filters fixed. Activities and Records render latest first * Merge pull request #37 from harshitav-docusign/BugBashFixes SalesCopilot: Recipient names as array. Status to TitleCase. DocumentNLP formatting * Adding back PPDF tranformation fields * Fix spacing issues * Transfering DocuSign demo code to DocuSign prod connector * Porting changes from DocuSign demo dev to MSFlow.DS1003.10.17.2023 * Fix the title and description specific to Prod * Corrected the swagger. Removed envelopeId from responseMerge pull request #38 from harshitav-docusign/swagger_updates Fixed swagger errors. Remove envelope Id from the description * removed merge conflicts * Additional properties fixed. DateTime formatted * Added local time and additional properties * Remove the Max payload exceed messaging * Remove changes in the DocuSign folder * Remove Connect error handling to DocuSign Prod --------- Co-authored-by: Srihari Padmanabhan <[email protected]> Co-authored-by: Srihari Padmanabhan <[email protected]> Co-authored-by: Angel Garcia Reyes <[email protected]> Co-authored-by: Mahbub Murshed <[email protected]>
harshitav-docusign
added a commit
that referenced
this pull request
Oct 3, 2024
* FLOW-427: Support "Transform PDF fields to DocuSign tabs" in Power Automate * Updated the text and rearranged the Signature type position * Add signatureType implementation * modularize the signatureType block * Optimized code * REmoved enum * recipient events are added to V3 connect * Fix SMS issue * Add tooltip * Fixing DS EU Qualified signature type * Added support to checkbox and radio button * Checkbox and radio button code added to trigger * Enable COC added on selecting Combined option * rename the sataticSchema definition * String replace fixed * Add checkbox and radio button to the tabs output * zip header added * Removed statis response for certificate * Removed Log Information * Sales copilot custom actions are added * Update title with lower case * Sales copilot custom actions are added (cherry picked from commit 90c0601) * Update title with lower case (cherry picked from commit 9b6111c) * Release candidate DS1003 created * Build number updated * CRMOrgUrl issue fixed. Displaying records in the descending order. recordId filtering fixed * recordId and OrgURL is fixed. Descending order of the activities implemented * renamed activities and documentsRecords to follow camelcase naming pattern * Recipient names as array. Status to TitleCase. DocumentNLP formatting * DocumentNaturalLanguage reformatted * cherry picking from harshita devMerge pull request #37 from harshitav-docusign/BugBashFixes SalesCopilot: Recipient names as array. Status to TitleCase. DocumentNLP formatting * Merged bug fixesMerge pull request #36 from harshitav-docusign/recordId_issue RecordId and OrgUrl filters fixed. Activities and Records render latest first * Merge pull request #37 from harshitav-docusign/BugBashFixes SalesCopilot: Recipient names as array. Status to TitleCase. DocumentNLP formatting * Adding back PPDF tranformation fields * Fix spacing issues * Transfering DocuSign demo code to DocuSign prod connector * Porting changes from DocuSign demo dev to MSFlow.DS1003.10.17.2023 * Fix the title and description specific to Prod * Fix swagger errors. Remove envelope Id from the description * Corrected the swagger. Removed envelopeId from responseMerge pull request #38 from harshitav-docusign/swagger_updates Fixed swagger errors. Remove envelope Id from the description * removed merge conflicts * Update DocumentId to Output Format * Additional properties fixed. DateTime formatted * Additional properties fixed. DateTime formatted * Added local time and additional properties * Add reminders code added * remove ms-test-value * Add response * corrected the spelling error * Lock functionality added * Removed the text tab lock and added lock to all the tabs * Add optional property for the tab * Added recipient Type to the output of the get recipient info * Modify the default date to older date * Saleforce support is added to copilot * Add the error handling * Increment build number * Flow-512-b * Embedded recipient type feature added * Remove remote option * convert to string * string conversion implemented * label name updated * remove the AddParam method * Add entityLogicName * migrating DocuSign demo connector code to DocuSign connector * Update swagger file metadata * Void envelope added * Resend custom action added * Get recipient information added * Required output added * Documents added * Remove the Max payload exceed messaging * Remove changes in the DocuSign folder * Flow-532 * Filters working for most of the cases * Working for status, emailid * remove debuggin lines * Implemented sorting order, Skip and top, folder-Ids * updated the description * Added expiry after in the Add reminder for envelope * Added custom field support * Fixed indendation * Add custom name search field * correct the customFieldName * correct the spell error * Bunmping the release number * Prod branch for DS1006 release created * correct the host name * Update the description * Branding update added * Resend envelope AI enabled * ListEnvelope for sales copilot added * Migrated code from demo to Prod * Undo prod related texts * spell corrections * Update spelling error * fixed the if case at filteredEnvelopes * Remove extra brackets * to and from Date propertiews updates. Resend automatically picks up the Account id * Key sales custom action added * Email summary added * update the connector description to be within character limit. * Prod code updated * Update description of the demo connector. * Descriptions updated to related activities and records * Email summary and Key sales info are tested to be working * Update the description * Update background color to white * swagger updates are made and protocol is filtered for crmOrgURL * Update the description * Check for forward slash and update the parameter * Add recipientGuid. Add TabInfo in the tabs * add decline tab to add tabs action * support all tab types * Read hostURL from the context * Rename the host url methods and optimise the GetEnvelopeURL code * Renaming variables * UpdateDSDemoDescription * Upgrade the version number * FLOW-198 suuport all tab types * remove unused array * FLOW-20 Apply a template * Fix sales copilot Email Summary issue * Updated the description of List envelopes * Hostname changes ported from Prod connector * Update the end date description * FLOW-623 numerical tab field update * FLOW-623 update numerical value field label * FLOW-629 document ID field added to Checkbox groups * get tab info action does not support tab groups * Update the spelling of the associated word --------- Co-authored-by: Srihari Padmanabhan <[email protected]> Co-authored-by: Srihari Padmanabhan <[email protected]> Co-authored-by: Young Seok Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.
apiDefinition.swagger.json, by runningpaconn validatecommand.apiProperties.jsonhas a valid brand color and doesn't use an invalid brand color,#007ee5or#ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process: