-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Includes and String requirement on Paths #51
Comments
This is a intended in liquidjs, to support dynamic including. All built-in tags can be override by register a new Tag, you can simply write your |
Published @ 2.2.0. Setting |
Oh, wow! Amazing—thank you!! |
zachleat
added a commit
to 11ty/eleventy
that referenced
this issue
Dec 21, 2017
This was referenced Mar 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
(Love this library—thank you!)
This is going to be a very specific nitpick so just keep that in mind. I wanted to use this lib to parse some existing Jekyll templates and while I don’t expect a completely fluid parse, one thing that did trip me up: Jekyll includes.
Specifically, Jekyll uses
{% include footer.html %}
(without quotes) and this library expects{% include 'footer.html' %}
(quotes). I suppose I just have a question: is this a limitation of the library (something that could be worked around) or a limitation of any non-Ruby implementation?Thanks!
Zach
The text was updated successfully, but these errors were encountered: