Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsing should fail if {% else foo = 'blah' %} #713

Closed
amit777 opened this issue Jul 4, 2024 · 1 comment
Closed

parsing should fail if {% else foo = 'blah' %} #713

amit777 opened this issue Jul 4, 2024 · 1 comment
Labels

Comments

@amit777
Copy link
Contributor

amit777 commented Jul 4, 2024

I don't believe this should be valid syntax:

{% if foo %} foo
{% else foo = 'blah' %}
{% endif %}

If there is stuff after the {% else ... %} I believe there should be a parse error?

@amit777
Copy link
Contributor Author

amit777 commented Jul 8, 2024

thanks for the quick patch on this! And nice catches on potential ordering issues with elsif and else. I didn't think of that but it's definitely possible to happen.

github-actions bot pushed a commit that referenced this issue Jul 9, 2024
# [10.15.0](v10.14.0...v10.15.0) (2024-07-09)

### Bug Fixes

* report error for malformed else/elsif/endif/endfor, [#713](#713) ([22b5a12](22b5a12))

### Features

* DoS prevention, [#250](#250) ([e443068](e443068))
* support in-memory template mapping, inspired by [@jg-rp](https://github.com/jg-rp) [#714](#714) ([df27ac6](df27ac6))
@harttle harttle closed this as completed Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants