Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune old code for Journals/Faculty sign-ups #3599

Conversation

cmsetzer
Copy link
Contributor

@cmsetzer cmsetzer commented Sep 6, 2024

In #3595 we removed links to the separate Journals and Faculty sign-up forms. This branch removes the (now unused) code for those views and associated tests.

@cmsetzer cmsetzer requested a review from a team as a code owner September 6, 2024 18:48
@cmsetzer cmsetzer requested review from bensteinberg and removed request for a team September 6, 2024 18:48
@rebeccacremona
Copy link
Contributor

YES!

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.80%. Comparing base (bde0aa3) to head (2d06433).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3599      +/-   ##
===========================================
- Coverage    68.84%   68.80%   -0.05%     
===========================================
  Files           48       48              
  Lines         7004     7000       -4     
===========================================
- Hits          4822     4816       -6     
- Misses        2182     2184       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmsetzer cmsetzer merged commit ea2e497 into harvard-lil:develop Sep 6, 2024
2 checks passed
@cmsetzer cmsetzer deleted the remove-dead-code-for-journals-and-faculty branch September 6, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants