fits scripts should resolve symlinks before loading relative paths #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This resolves a rather problematic issue of not being able to symlink to fits.sh from /usr/local/bin |
|
For anyone who is trying to install fits.sh and then symlink to it from somewhere canonical, running the following from the fits.sh directory will apply this patch. wget -O 90.patch https://github.com/harvard-lts/fits/pull/90.patch
patch -p1 < 90.patch |
|
I've seen this issue before when trying to setup FITS (e.g., when building a Vagrant environment). Merging this would help make it easier to setup FITS. |
|
👍 (It'd be nice to not have to parse |
|
Thanks for the contribution. This will be included in a new release within the next few weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.