-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small modification to allow searching through the entire word (not just the beginning). #212
Conversation
…st the beginning).
…st the beginning).
…st the beginning).
…st the beginning).
…st the beginning).
…st the beginning).
+1 for this change |
1 similar comment
+1 for this change |
+1 for this |
+1 for this change |
+1. It would be nice if this were implemented as a boolean option, where setting fullTextSearch to True would cause this behaviour. |
+1 for this changes, too! - And +1 for adding the setting/option (i.e.) "fullTextSearch" (like mikery said in the last comment). please |
Can this be merged into head if it works well please? |
I am actually pretty opposed to making this be the default search behavior in Chosen. I believe that, in most cases, a user does not expect to see the middle of words match. When I start a search with "un", I do not expect to see Burundi, Hungary and Tunisa. If I wanted those results, I would type for those results. However, there is clearly a fair amount of demand for this solution and I would welcome a pull request adding it as an option (NOT the default). There are situations where matching the middle of words could make sense (complicated product / medical names have been cited as good examples). In the meantime, closing this request. Thanks for the discussion, @ALL. |
#299 actually does this well. Looking at that now. |
@pfiller Whoops, turns out this is not the merge I was looking for in the first place. I was looking for the one that fixed searches for words surrounded by parentheses. Like (foo bar) - foo couldn't be found last time I checked. |
I made a small modification in the code that made the search feature much more useful for my team.
Please see if it is at all useful for you and I welcome any feedback.