Fix printer state #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisab85
reviewed
Apr 21, 2024
There was a problem hiding this comment.
According to the RFC 8011 standard (refer to page 152), the expected value should be an integer between 3 and 5. The proposed implementation using a string deviates from this standard. To enhance compatibility and adhere to the standard, it would be beneficial to continue supporting integer values. If there's a specific need to parse textual values, perhaps we could implement this feature in a way that both formats are acceptable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix setting printer state (comparison by state name instead of value) - reported in #52 and #62