Merge pull request cri-o#7503 from haircommander/fix-pids-limit-default

config: set default pids limit to -1
hasan4791 · Dec 5, 2023 · 98264a1 · 98264a1
2 parents c4afa28 + 37b3754
commit 98264a1
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/docs/crio.8.md b/docs/crio.8.md
@@ -356,7 +356,7 @@ crio [GLOBAL OPTIONS] command [COMMAND OPTIONS] [ARGUMENTS...]
 
 **--pause-image-auth-file**="": Path to a config file containing credentials for --pause-image.
 
-**--pids-limit**="": Maximum number of processes allowed in a container. This option is deprecated. The Kubelet flag '--pod-pids-limit' should be used instead. (default: 0)
+**--pids-limit**="": Maximum number of processes allowed in a container. This option is deprecated. The Kubelet flag '--pod-pids-limit' should be used instead. (default: -1)
 
 **--pinned-images**="": A list of images that will be excluded from the kubelet's garbage collection.
 

diff --git a/docs/crio.conf.5.md b/docs/crio.conf.5.md
@@ -236,7 +236,7 @@ the container runtime configuration.
 
     2) `/usr/share/containers/mounts.conf`: This is the default file read for mounts. If you want CRI-O to read from a different, specific mounts file, you can change the default_mounts_file. Note, if this is done, CRI-O will only add mounts it finds in this file.
 
-**pids_limit**=0
+**pids_limit**=-1
   Maximum number of processes allowed in a container.
   This option is deprecated. The Kubelet flag `--pod-pids-limit` should be used instead.
 

diff --git a/pkg/config/config.go b/pkg/config/config.go
@@ -104,7 +104,7 @@ const (
 const (
 	// DefaultPidsLimit is the default value for maximum number of processes
 	// allowed inside a container
-	DefaultPidsLimit = 0
+	DefaultPidsLimit = -1
 
 	// DefaultLogSizeMax is the default value for the maximum log size
 	// allowed for a container. Negative values mean that no limit is imposed.