Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove workflow that doesnt work for other forks #1012

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove workflow that doesnt work for other forks #1012

wants to merge 3 commits into from

Conversation

mgarbs
Copy link
Collaborator

@mgarbs mgarbs commented Jul 16, 2024 •
edited
Loading

This PR adds the ability for the assign hip number and rename file worklow to work with forks

  • Use pull_request_target to handle PRs from forks with base repo permissions
  • Checkout both head and base repositories for accurate diff and reference
  • Identify new HIP files in the PR and assign HIP numbers based on PR number
  • Rename new HIP files to include assigned HIP numbers
  • Commit and push changes back to the PR branch

@mgarbs
Update workflow to assign HIP numbers and rename files for PRs
65734f7 
- Use pull_request_target to handle PRs from forks with base repo permissions
- Checkout both head and base repositories for accurate diff and reference
- Identify new HIP files in the PR and assign HIP numbers based on PR number
- Rename new HIP files to include assigned HIP numbers
- Commit and push changes back to the PR branch

Signed-off-by: Michael Garber <[email protected]>
@mgarbs mgarbs requested review from a team as code owners July 16, 2024 16:10
@netlify Netlify
Copy link

netlify bot commented Jul 16, 2024 •
edited
Loading

✅ Deploy Preview for hedera-hips ready!

Name Link
🔨 Latest commit ba14c9a
🔍 Latest deploy log https://app.netlify.com/sites/hedera-hips/deploys/669919a02b9d5a0008817e22
😎 Deploy Preview https://deploy-preview-1012--hedera-hips.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tinker-michaelj
tinker-michaelj previously approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense @mgarbs , thanks!

@mgarbs mgarbs marked this pull request as draft July 18, 2024 13:08
@mgarbs mgarbs changed the title Update workflow to assign HIP numbers and rename files for PRs Remove workflow that doesnt work for other forks Jul 18, 2024
@mgarbs mgarbs marked this pull request as ready for review July 18, 2024 13:34
sergmetelin
sergmetelin approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@sergmetelin sergmetelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergmetelin sergmetelin sergmetelin approved these changes

@tinker-michaelj tinker-michaelj tinker-michaelj left review comments

@matteriben matteriben Awaiting requested review from matteriben matteriben was automatically assigned from hashgraph/release-engineering

@nathanklick nathanklick Awaiting requested review from nathanklick nathanklick was automatically assigned from hashgraph/release-engineering-managers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgarbs @sergmetelin @tinker-michaelj