-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daily rewards for active nodes #1064
base: main
Are you sure you want to change the base?
Daily rewards for active nodes #1064
Conversation
✅ Deploy Preview for hedera-hips ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
1a2f249
to
ca7ed2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some wording improvements, a few suggestions for different arrangement, and improvements to specification protocol buffer text.
e098b2e
to
b9e961a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @Neeharika-Sompalli
fafb83f
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Neeharika Sompalli <[email protected]> Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Neeharika Sompalli <[email protected]> Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Neeharika Sompalli <[email protected]> Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Neeharika Sompalli <[email protected]> Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Neeharika Sompalli <[email protected]> Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Neeharika Sompalli <[email protected]> Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Neeharika Sompalli <[email protected]> Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Neeharika Sompalli <[email protected]> Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Neeharika Sompalli <[email protected]> Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Neeharika Sompalli <[email protected]> Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
8303a47
to
72146fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A question about the added definition for judges.
<dd>An event that wins the election to be made a judge. It must be a witness, and it will have tended to have been | ||
gossiped to most of the other nodes quickly (otherwise it would have lost the election). An event reaches consensus | ||
when it is an ancestor of all judges in a given round. The first round where that happens is its consensus round. | ||
It’s a math theorem that every round is guaranteed to have at least one judge, and a math conjecture that every round | ||
is guaranteed to have judges created by a supermajority of nodes (>2/3 of weight).</dd> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This confuses me a bit.
Does the following express the same concepts?
<dd>An event that wins the election to be made a judge. It must be a witness, and it will have tended to have been | |
gossiped to most of the other nodes quickly (otherwise it would have lost the election). An event reaches consensus | |
when it is an ancestor of all judges in a given round. The first round where that happens is its consensus round. | |
It’s a math theorem that every round is guaranteed to have at least one judge, and a math conjecture that every round | |
is guaranteed to have judges created by a supermajority of nodes (>2/3 of weight).</dd> | |
<dd>An event wins an election to be made a judge. To win the election an event | |
must be a witness, and it will tend to be gossiped to most of the other nodes | |
quickly (otherwise it would have lost the election). | |
An event reaches consensus when it is an ancestor of all judges in a given round. | |
The first round where that happens is its consensus round. It is a mathematic | |
theorem that every round is guaranteed to have at least one judge, and a | |
mathematic conjecture that every round is guaranteed to have judges created | |
by a supermajority of nodes (>2/3 of consensus weight).</dd> |
One thing that is missing:
What is the actual criteria for "winning" the election?
Is it the first set of events that qualify as witnesses for the round?
Is it the first set of events that qualify as "famous witnesses"?
Creates a HIP for proposing daily rewards for active nodes