Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daily rewards for active nodes #1064

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

Neeharika-Sompalli
Copy link
Member

Creates a HIP for proposing daily rewards for active nodes

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for hedera-hips ready!

Name Link
🔨 Latest commit 72146fd
🔍 Latest deploy log https://app.netlify.com/sites/hedera-hips/deploys/672d0f10f89cea000835a2d0
😎 Deploy Preview https://deploy-preview-1064--hedera-hips.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

HIP/hip-1064.md Outdated Show resolved Hide resolved
HIP/hip-1064.md Outdated Show resolved Hide resolved
HIP/hip-1064.md Outdated Show resolved Hide resolved
Copy link
Member

@jsync-swirlds jsync-swirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some wording improvements, a few suggestions for different arrangement, and improvements to specification protocol buffer text.

HIP/hip-1064.md Outdated Show resolved Hide resolved
HIP/hip-1064.md Show resolved Hide resolved
HIP/hip-1064.md Outdated Show resolved Hide resolved
HIP/hip-1064.md Outdated Show resolved Hide resolved
HIP/hip-1064.md Outdated Show resolved Hide resolved
HIP/hip-1064.md Outdated Show resolved Hide resolved
HIP/hip-1064.md Outdated Show resolved Hide resolved
HIP/hip-1064.md Outdated Show resolved Hide resolved
HIP/hip-1064.md Outdated Show resolved Hide resolved
HIP/hip-1064.md Outdated Show resolved Hide resolved
HIP/hip-1064.md Outdated Show resolved Hide resolved
jsync-swirlds
jsync-swirlds previously approved these changes Oct 18, 2024
HIP/hip-1064.md Outdated Show resolved Hide resolved
netopyr
netopyr previously approved these changes Oct 21, 2024
Copy link
Contributor

@netopyr netopyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @Neeharika-Sompalli

Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Neeharika-Sompalli and others added 15 commits November 7, 2024 13:03
Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]>
Signed-off-by: Neeharika Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]>
Signed-off-by: Neeharika Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]>
Signed-off-by: Neeharika Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]>
Signed-off-by: Neeharika Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]>
Signed-off-by: Neeharika Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]>
Signed-off-by: Neeharika Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]>
Signed-off-by: Neeharika Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]>
Signed-off-by: Neeharika Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]>
Signed-off-by: Neeharika Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Co-authored-by: Joseph S. <[email protected]>
Signed-off-by: Neeharika Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Copy link
Member

@jsync-swirlds jsync-swirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question about the added definition for judges.

Comment on lines +27 to +31
<dd>An event that wins the election to be made a judge. It must be a witness, and it will have tended to have been
gossiped to most of the other nodes quickly (otherwise it would have lost the election). An event reaches consensus
when it is an ancestor of all judges in a given round. The first round where that happens is its consensus round.
It’s a math theorem that every round is guaranteed to have at least one judge, and a math conjecture that every round
is guaranteed to have judges created by a supermajority of nodes (>2/3 of weight).</dd>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This confuses me a bit.
Does the following express the same concepts?

Suggested change
<dd>An event that wins the election to be made a judge. It must be a witness, and it will have tended to have been
gossiped to most of the other nodes quickly (otherwise it would have lost the election). An event reaches consensus
when it is an ancestor of all judges in a given round. The first round where that happens is its consensus round.
It’s a math theorem that every round is guaranteed to have at least one judge, and a math conjecture that every round
is guaranteed to have judges created by a supermajority of nodes (>2/3 of weight).</dd>
<dd>An event wins an election to be made a judge. To win the election an event
must be a witness, and it will tend to be gossiped to most of the other nodes
quickly (otherwise it would have lost the election).
An event reaches consensus when it is an ancestor of all judges in a given round.
The first round where that happens is its consensus round. It is a mathematic
theorem that every round is guaranteed to have at least one judge, and a
mathematic conjecture that every round is guaranteed to have judges created
by a supermajority of nodes (>2/3 of consensus weight).</dd>

One thing that is missing:
What is the actual criteria for "winning" the election?
Is it the first set of events that qualify as witnesses for the round?
Is it the first set of events that qualify as "famous witnesses"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants