Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FInalise the design of eth_getTransactionCount for Contracts #165

Closed
Daniel-K-Ivanov opened this issue Jun 7, 2022 · 1 comment
Closed
Labels
design Design, pilot and prototyping exploration work enhancement New feature or request limechain P2 question Further information is requested
Milestone

Comments

@Daniel-K-Ivanov
Copy link
Collaborator

Problem
Nonces for a contract are 1 + n where n is the number of times the contract created other contracts through CREATE or CREATE2. The deployment of the contract itself is considered part of the nonce, that's why the nonce starts from 1.

Currently eth_getTransactionCount for contracts returns hardcoded value of 1.

Solution
Clear out how services will handle nonces for contracts and whether they will do something with nonces. Once the design is defined, a discussion on how to handle them on the relay side must be conducted.

A potential solution for services -> Update the nonce of the contract for every CREATE / CREATE2 opcode executed from it.

@Daniel-K-Ivanov Daniel-K-Ivanov added design Design, pilot and prototyping exploration work question Further information is requested labels Jun 7, 2022
@Nana-EC Nana-EC added the enhancement New feature or request label Jun 14, 2022
@Nana-EC Nana-EC added this to the 0.3.0 milestone Jun 20, 2022
@Nana-EC Nana-EC modified the milestones: 0.3.0, 0.4.0 Jul 5, 2022
@Kalina-Todorova
Copy link

Filed a ticket in hedera-services to address this: hashgraph/hedera-services#3640

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design, pilot and prototyping exploration work enhancement New feature or request limechain P2 question Further information is requested
Projects
Archived in project
Development

No branches or pull requests

3 participants