Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the nonce of the contract account for every CREATE opcode executed from it #3640

Closed
Tracked by #6512
Kalina-Todorova opened this issue Jul 6, 2022 · 0 comments · Fixed by #6934
Closed
Tracked by #6512

Update the nonce of the contract account for every CREATE opcode executed from it #3640

Kalina-Todorova opened this issue Jul 6, 2022 · 0 comments · Fixed by #6934
Assignees
@MiroslavGatsanoga @agadzhalov
Labels
Bug An error that causes the feature to behave differently than what was expected based on design. Limechain Work planned for the LimeChain team P2 Required to be completed in the assigned milestone, but may or may not impact the release schedule.
Milestone
v0.40

Comments

@Kalina-Todorova
Copy link

Kalina-Todorova commented Jul 6, 2022 •
edited by stoqnkpL
Loading

Caught while working on the JSON-RPC Relay:
hashgraph/hedera-json-rpc-relay#165
Depending on: hashgraph/hedera-protobufs#245
We'll need to:

  • add the nonce changes to the contractFnResult of the top level transaction in a map of contractID → nonce
  • check what rpcs need to support this and what mirror node endpoints need to return it
  • eth receipts we create will have a field for new account nonce
@Kalina-Todorova Kalina-Todorova added P2 Required to be completed in the assigned milestone, but may or may not impact the release schedule. Bug An error that causes the feature to behave differently than what was expected based on design. labels Jul 6, 2022
@Kalina-Todorova Kalina-Todorova mentioned this issue Jul 6, 2022
Closed
@IvanKavaldzhiev IvanKavaldzhiev added the Limechain Work planned for the LimeChain team label Oct 27, 2022
@IvanKavaldzhiev IvanKavaldzhiev self-assigned this Nov 3, 2022
@stoqnkpL stoqnkpL changed the title Update the nonce of the contract account for every CREATE / CREATE2 opcode executed from it Update the nonce of the contract account for every CREATE opcode executed from it Nov 16, 2022
@stoqnkpL stoqnkpL mentioned this issue Nov 16, 2022
Open
@MiroslavGatsanoga MiroslavGatsanoga self-assigned this May 4, 2023
@MiroslavGatsanoga MiroslavGatsanoga mentioned this issue May 9, 2023
Closed
10 tasks
@agadzhalov agadzhalov self-assigned this May 25, 2023
@agadzhalov agadzhalov mentioned this issue Jun 5, 2023
Merged
@MiroslavGatsanoga MiroslavGatsanoga added this to the v0.40 milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MiroslavGatsanoga MiroslavGatsanoga

@agadzhalov agadzhalov

Labels
Bug An error that causes the feature to behave differently than what was expected based on design. Limechain Work planned for the LimeChain team P2 Required to be completed in the assigned milestone, but may or may not impact the release schedule.
Projects
Smart Contract Sprint Board
Archived in project
Milestone
v0.40
Development

Successfully merging a pull request may close this issue.

03640 Contract create nonce externalization hashgraph/hedera-services
5 participants
@IvanKavaldzhiev @MiroslavGatsanoga @dimitar-dinev @agadzhalov @Kalina-Todorova