Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contract nonces related fields #257

Merged
merged 12 commits into from
May 31, 2023

Conversation

MiroslavGatsanoga
Copy link
Contributor

@MiroslavGatsanoga MiroslavGatsanoga commented Feb 1, 2023

Signed-off-by: Miroslav Gatsanoga [email protected]

Description:

Related issue(s):

Notes for reviewer:

Adding protobuf changes for HIP-729.

Copy link

@MarcKriguerAtHedera MarcKriguerAtHedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Signed-off-by: Stoyan Panayotov <[email protected]>
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Nana-EC Nana-EC requested a review from rbair23 February 2, 2023 17:54
Nana-EC
Nana-EC previously approved these changes Feb 2, 2023
services/crypto_get_info.proto Outdated Show resolved Hide resolved
services/contract_call_local.proto Outdated Show resolved Hide resolved
Signed-off-by: Miroslav Gatsanoga <[email protected]>
steven-sheehy
steven-sheehy previously approved these changes May 9, 2023
Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xin-hedera
xin-hedera previously approved these changes May 9, 2023
Copy link
Contributor

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nana-EC
Nana-EC previously approved these changes May 18, 2023
services/contract_call_local.proto Outdated Show resolved Hide resolved
services/contract_call_local.proto Outdated Show resolved Hide resolved
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Signed-off-by: Miroslav Gatsanoga <[email protected]>
@Nana-EC Nana-EC added the enhancement New feature or request label May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

10 participants