refactor: Extract fromConfig() logic from Client #2036
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
Client
-Class gained some considerable size over time. I refactored theClient
-Class a bit to make theClient.fromConfig()
-construction logic more clear and to shrink the Client Class, by extracting the logic to the innerConfig
class.Downside:
Client
andConfig
now have a bidirectional relationship, making this a little harder to understand. But the Config class is private to the Client class, so this added complexity does not leak outside.Looking forward to your opinions regarding this refactorings.
This PR modifies ... in order to support ...
Client.fromConfig
-Construction logic toConfig
classRelated issue(s):
Fixes #
Notes for reviewer:
Checklist