Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the addressbook on SDK build #1658

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

petreze
Copy link
Contributor

@petreze petreze commented Jun 29, 2023

Description:
This PR adds task update:addressbooks inside task build so that the address book of the SDK gets updated whenever task build is run, which basically prepares the SDK for use
Related issue(s):

Fixes #1657

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Petar Tonev <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@petreze petreze changed the title Update the addressbook on sdk build Update the addressbook on SDK build Jun 30, 2023
@ochikov ochikov merged commit 3ecd5cd into develop Jun 30, 2023
9 of 10 checks passed
@ochikov ochikov deleted the feature/update-addressbook-on-build branch June 30, 2023 09:19
monokaijs pushed a commit to monostarter/u2u-sdk-js that referenced this pull request Jul 5, 2023
* update the addressbook on sdk build

Signed-off-by: Petar Tonev <[email protected]>

* rearrange tasks

Signed-off-by: Petar Tonev <[email protected]>

---------

Signed-off-by: Petar Tonev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the addressbook on SDK build
2 participants