Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change FEE_SCHEDULE_FILE_PART_UPLOADED to not show as an error #2537

Merged
merged 6 commits into from
Oct 4, 2024

Conversation

ivaylonikolov7
Copy link
Contributor

Description:
Updates TransactionResponse to not throw ReceiptStatus error and mark the receipt as finished

Related issue(s): #2501

Fixes #2501

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ivaylonikolov7 ivaylonikolov7 requested review from a team as code owners September 19, 2024 20:35
@ivaylonikolov7 ivaylonikolov7 self-assigned this Sep 19, 2024
@ivaylonikolov7 ivaylonikolov7 added this to the v2.52.0 milestone Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.41%. Comparing base (596d115) to head (3e64ab7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2537      +/-   ##
==========================================
+ Coverage   84.39%   84.41%   +0.01%     
==========================================
  Files         283      283              
  Lines       71017    71021       +4     
==========================================
+ Hits        59938    59951      +13     
+ Misses      11079    11070       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Copy link
Contributor

@ivaylogarnev-limechain ivaylogarnev-limechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Oct 4, 2024

@ivaylonikolov7 ivaylonikolov7 merged commit 2a4e21d into main Oct 4, 2024
13 checks passed
@ivaylonikolov7 ivaylonikolov7 deleted the feat/fee_schedule_file_part_uploaded_error branch October 4, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEE_SCHEDULE_FILE_PART_UPLOADED marked as error
4 participants