Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change failInvalidOutsideDispatchDoesNotAttemptToChargeFees() for refactored ScheduleService schema #16328

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

tinker-michaelj
Copy link
Collaborator

@tinker-michaelj tinker-michaelj commented Oct 30, 2024

Description:

  • Updates the state "corruption" used in this embedded test to target the updated ScheduleService schemas.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.03% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2c30a3a) 95938 61990 64.61%
Head commit (ca6a085) 95938 (+0) 62022 (+32) 64.65% (+0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16328) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.92%. Comparing base (2c30a3a) to head (ca6a085).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16328      +/-   ##
=============================================
+ Coverage      62.88%   62.92%   +0.03%     
- Complexity     19919    19920       +1     
=============================================
  Files           2519     2519              
  Lines          93119    93119              
  Branches        9786     9786              
=============================================
+ Hits           58562    58593      +31     
+ Misses         30991    30959      -32     
- Partials        3566     3567       +1     

see 2 files with indirect coverage changes

Impacted file tree graph

Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tinker-michaelj tinker-michaelj merged commit 7fe8ebe into develop Oct 31, 2024
56 of 64 checks passed
@tinker-michaelj tinker-michaelj deleted the fix-simultaneous-merges branch October 31, 2024 01:16
Evdokia-Georgieva pushed a commit that referenced this pull request Oct 31, 2024
…for refactored ScheduleService schema (#16328)

Signed-off-by: Michael Tinker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants