-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Block Signing protobufs #16426
Conversation
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Node: HAPI Test (Restart) Results7 tests 1 ✅ 2m 36s ⏱️ For more details on these parsing errors and failures, see this check. Results for commit 8d96a94. ♻️ This comment has been updated with latest results. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #16426 +/- ##
=============================================
+ Coverage 63.32% 63.35% +0.02%
- Complexity 20060 20093 +33
=============================================
Files 2523 2527 +4
Lines 93554 93659 +105
Branches 9802 9804 +2
=============================================
+ Hits 59244 59338 +94
- Misses 30709 30722 +13
+ Partials 3601 3599 -2
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
hapi/hedera-protobufs/services/auxiliary/tss/tss_share_signature.proto
Outdated
Show resolved
Hide resolved
hedera-node/hedera-config/src/main/java/com/hedera/node/config/data/TssConfig.java
Outdated
Show resolved
Hide resolved
hedera-node/hedera-config/src/main/java/com/hedera/node/config/data/TssConfig.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks 👍 @Neeharika-Sompalli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proto files need more detail, in appropriate format.
hapi/hedera-protobufs/services/auxiliary/tss/tss_share_signature.proto
Outdated
Show resolved
Hide resolved
hapi/hedera-protobufs/services/auxiliary/tss/tss_share_signature.proto
Outdated
Show resolved
Hide resolved
hapi/hedera-protobufs/services/auxiliary/tss/tss_share_signature.proto
Outdated
Show resolved
Hide resolved
hapi/hedera-protobufs/services/auxiliary/tss/tss_share_signature.proto
Outdated
Show resolved
Hide resolved
…re.proto Co-authored-by: Joseph S. <[email protected]> Signed-off-by: Neeharika Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good improvement, still a couple small items.
hapi/hedera-protobufs/services/auxiliary/tss/tss_share_signature.proto
Outdated
Show resolved
Hide resolved
hapi/hedera-protobufs/services/auxiliary/tss/tss_share_signature.proto
Outdated
Show resolved
Hide resolved
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with respect to the .proto
files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean changeset, tyvm @Neeharika-Sompalli !
Fixes #16422
TssShareSignatureTransactionHandler
which will be implemented in next PR