Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Block Signing protobufs #16426

Merged
merged 10 commits into from
Nov 6, 2024

Conversation

Neeharika-Sompalli
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli commented Nov 4, 2024

Fixes #16422

  • Adds protobufs and cnfigurations for Block Signing
  • Adds empty TssShareSignatureTransactionHandler which will be implemented in next PR

Signed-off-by: Neeharika-Sompalli <[email protected]>
Copy link

github-actions bot commented Nov 4, 2024

Node: HAPI Test (Restart) Results

7 tests   1 ✅  2m 36s ⏱️
8 suites  0 💤
9 files    6 ❌
1 errors

For more details on these parsing errors and failures, see this check.

Results for commit 8d96a94.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 63.35%. Comparing base (420eee2) to head (8c2e9d4).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
...ode/app/tss/handlers/TssShareSignatureHandler.java 14.28% 6 Missing ⚠️
.../src/main/java/com/hedera/hapi/util/HapiUtils.java 0.00% 1 Missing ⚠️
...pp/workflows/dispatcher/TransactionDispatcher.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16426      +/-   ##
=============================================
+ Coverage      63.32%   63.35%   +0.02%     
- Complexity     20060    20093      +33     
=============================================
  Files           2523     2527       +4     
  Lines          93554    93659     +105     
  Branches        9802     9804       +2     
=============================================
+ Hits           59244    59338      +94     
- Misses         30709    30722      +13     
+ Partials        3601     3599       -2     
Files with missing lines Coverage Δ
...m/hedera/node/app/services/ServiceScopeLookup.java 34.78% <100.00%> (-4.35%) ⬇️
...va/com/hedera/node/app/tss/TssBaseServiceImpl.java 62.83% <100.00%> (+1.01%) ⬆️
.../com/hedera/node/app/tss/handlers/TssHandlers.java 100.00% <100.00%> (ø)
.../app/workflows/dispatcher/TransactionHandlers.java 100.00% <ø> (ø)
...ode/app/workflows/handle/HandleWorkflowModule.java 100.00% <100.00%> (ø)
...m/hedera/node/config/data/ApiPermissionConfig.java 100.00% <100.00%> (ø)
...in/java/com/hedera/node/config/data/TssConfig.java 100.00% <ø> (ø)
.../src/main/java/com/hedera/hapi/util/HapiUtils.java 59.55% <0.00%> (-0.34%) ⬇️
...pp/workflows/dispatcher/TransactionDispatcher.java 38.77% <0.00%> (-1.44%) ⬇️
...ode/app/tss/handlers/TssShareSignatureHandler.java 14.28% <14.28%> (ø)

... and 50 files with indirect coverage changes

Impacted file tree graph

Copy link

codacy-production bot commented Nov 4, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.03% (target: -1.00%) 50.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (420eee2) 96373 62707 65.07%
Head commit (8c2e9d4) 96319 (-54) 62645 (-62) 65.04% (-0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16426) 16 8 50.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Copy link
Contributor

@thomas-swirlds-labs thomas-swirlds-labs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks 👍 @Neeharika-Sompalli

Copy link
Member

@jsync-swirlds jsync-swirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proto files need more detail, in appropriate format.

…re.proto

Co-authored-by: Joseph S. <[email protected]>
Signed-off-by: Neeharika Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Copy link
Member

@jsync-swirlds jsync-swirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement, still a couple small items.

Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Copy link
Member

@jsync-swirlds jsync-swirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with respect to the .proto files.

Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean changeset, tyvm @Neeharika-Sompalli !

@Neeharika-Sompalli Neeharika-Sompalli merged commit 3596523 into develop Nov 6, 2024
51 of 52 checks passed
@Neeharika-Sompalli Neeharika-Sompalli deleted the 16422-16421-block-sign-protobufs branch November 6, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Protobufs and Configurations for Block Signing
4 participants