Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Removed old Schedule schema states. #16437

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

iwsimon
Copy link
Contributor

@iwsimon iwsimon commented Nov 5, 2024

Description:

Update develop version to 0.57 as well.

Related issue(s):

Fixes #16343

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Iris Simon <[email protected]>
@iwsimon iwsimon added this to the v0.57 milestone Nov 5, 2024
@iwsimon iwsimon self-assigned this Nov 5, 2024
@iwsimon iwsimon requested review from a team as code owners November 5, 2024 19:24
@iwsimon iwsimon added the HIP-423 label Nov 5, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.53% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (789e153) 96198 62107 64.56%
Head commit (39dd509) 96379 (+181) 62735 (+628) 65.09% (+0.53%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16437) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.36%. Comparing base (789e153) to head (39dd509).
Report is 11 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16437      +/-   ##
=============================================
+ Coverage      62.83%   63.36%   +0.53%     
- Complexity     19924    20083     +159     
=============================================
  Files           2524     2524              
  Lines          93379    93591     +212     
  Branches        9804     9801       -3     
=============================================
+ Hits           58671    59305     +634     
+ Misses         31134    30687     -447     
- Partials        3574     3599      +25     
Files with missing lines Coverage Δ
...ice/schedule/impl/schemas/V0570ScheduleSchema.java 95.83% <100.00%> (+0.08%) ⬆️

... and 74 files with indirect coverage changes

Impacted file tree graph

Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm @iwsimon !

Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version roll looks good to me.

@iwsimon iwsimon merged commit 9b0f656 into develop Nov 6, 2024
79 of 80 checks passed
@iwsimon iwsimon deleted the 16343-remove-state branch November 6, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove old schema state
5 participants