Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement block signing #16462

Draft
wants to merge 35 commits into
base: develop
Choose a base branch
from
Draft

Conversation

Neeharika-Sompalli
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli commented Nov 6, 2024

Fixes #16421

  • Implements TssShareSignatureHandler pre-handle logic
  • Uses submitting TssShareSignature transactions when keyCandidateRoster flag is set and uses real ledger signature instead of mock signature

Neeharika-Sompalli and others added 28 commits November 4, 2024 11:25
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Copy link

codacy-production bot commented Nov 6, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.09% (target: -1.00%) 47.98%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (52a7fce) 96496 62808 65.09%
Head commit (ac39f29) 96629 (+133) 62811 (+3) 65.00% (-0.09%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16462) 173 83 47.98%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 46.24277% with 93 lines in your changes missing coverage. Please review.

Project coverage is 63.25%. Comparing base (52a7fce) to head (ac39f29).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...ode/app/tss/handlers/TssShareSignatureHandler.java 16.66% 45 Missing ⚠️
...va/com/hedera/node/app/tss/TssBaseServiceImpl.java 23.40% 35 Missing and 1 partial ⚠️
...om/hedera/node/app/tss/TssKeyMaterialAccessor.java 74.19% 6 Missing and 2 partials ⚠️
...m/hedera/node/app/tss/handlers/TssSubmissions.java 84.61% 2 Missing ⚠️
...-app/src/main/java/com/hedera/node/app/Hedera.java 50.00% 1 Missing ⚠️
...app/workflows/standalone/TransactionExecutors.java 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16462      +/-   ##
=============================================
- Coverage      63.35%   63.25%   -0.10%     
+ Complexity     20097    20084      -13     
=============================================
  Files           2527     2528       +1     
  Lines          93677    93810     +133     
  Branches        9804     9813       +9     
=============================================
- Hits           59347    59340       -7     
- Misses         30731    30861     +130     
- Partials        3599     3609      +10     
Files with missing lines Coverage Δ
.../main/java/com/hedera/node/app/spi/AppContext.java 33.33% <ø> (ø)
...a/node/app/blocks/impl/BlockStreamManagerImpl.java 96.02% <100.00%> (ø)
...a/node/app/config/BootstrapConfigProviderImpl.java 87.50% <100.00%> (+0.54%) ⬆️
...a/com/hedera/node/app/services/AppContextImpl.java 100.00% <ø> (ø)
...com/hedera/node/app/tss/PlaceholderTssLibrary.java 72.34% <ø> (+4.25%) ⬆️
...n/java/com/hedera/node/app/tss/TssBaseService.java 25.00% <ø> (ø)
...edera/node/app/tss/handlers/TssMessageHandler.java 97.05% <100.00%> (-2.95%) ⬇️
...dera/node/app/workflows/handle/HandleWorkflow.java 83.85% <100.00%> (+1.55%) ⬆️
...in/java/com/hedera/node/config/data/TssConfig.java 100.00% <ø> (ø)
...latform/state/service/ReadableRosterStoreImpl.java 82.60% <100.00%> (+2.60%) ⬆️
... and 6 more

... and 18 files with indirect coverage changes

Impacted file tree graph

Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sign the block hash with the node share signatures and gossip TssShareSignatureTransaction
2 participants