Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NodeUpdate needs only admin key to sign #16495

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

iwsimon
Copy link
Contributor

@iwsimon iwsimon commented Nov 7, 2024

Description:

Related issue(s):

Fixes #16493

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@iwsimon iwsimon added the Dynamic Address Book All issues related to dynamic address book label Nov 7, 2024
@iwsimon iwsimon added this to the v0.57 milestone Nov 7, 2024
@iwsimon iwsimon self-assigned this Nov 7, 2024
@iwsimon iwsimon requested review from a team and jsync-swirlds as code owners November 7, 2024 22:17
Copy link

codacy-production bot commented Nov 7, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (700e95e) 96496 62809 65.09%
Head commit (ec6b18a) 96496 (+0) 62800 (-9) 65.08% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16495) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.34%. Comparing base (700e95e) to head (ec6b18a).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16495      +/-   ##
=============================================
- Coverage      63.35%   63.34%   -0.01%     
  Complexity     20100    20100              
=============================================
  Files           2527     2527              
  Lines          93677    93677              
  Branches        9804     9804              
=============================================
- Hits           59349    59344       -5     
- Misses         30730    30739       +9     
+ Partials        3598     3594       -4     
Files with missing lines Coverage Δ
...e/addressbook/impl/handlers/NodeUpdateHandler.java 93.05% <100.00%> (ø)
...era/node/app/authorization/PrivilegesVerifier.java 89.15% <100.00%> (ø)
...m/hedera/node/config/data/ApiPermissionConfig.java 100.00% <ø> (ø)

... and 8 files with indirect coverage changes

Impacted file tree graph

Copy link
Member

@jsync-swirlds jsync-swirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 86-87 should also be updated to remove reference to the council creating the transaction and the "if node operator created", as the node operator will always create.

hapi/hedera-protobufs/services/address_book_service.proto Outdated Show resolved Hide resolved
hapi/hedera-protobufs/services/address_book_service.proto Outdated Show resolved Hide resolved
hapi/hedera-protobufs/services/address_book_service.proto Outdated Show resolved Hide resolved
Signed-off-by: Iris Simon <[email protected]>
* network.
* - The node operator SHALL create an `updateNode` transaction.
* - The node operator MUST sign this transaction with the active `key`
* for the account assigned as the current "node account".
Copy link
Member

@jsync-swirlds jsync-swirlds Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node account key is only required if that field is changing.
The admin_key is the signature that is always required.

Suggested change
* for the account assigned as the current "node account".
* assigned as the `admin_key`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dynamic Address Book All issues related to dynamic address book
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NodeUpdate needs only admin key to sign.
2 participants