-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: NodeUpdate needs only admin key to sign #16495
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Iris Simon <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #16495 +/- ##
=============================================
- Coverage 63.35% 63.34% -0.01%
Complexity 20100 20100
=============================================
Files 2527 2527
Lines 93677 93677
Branches 9804 9804
=============================================
- Hits 59349 59344 -5
- Misses 30730 30739 +9
+ Partials 3598 3594 -4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 86-87 should also be updated to remove reference to the council creating the transaction and the "if node operator created", as the node operator will always create.
Signed-off-by: Iris Simon <[email protected]>
* network. | ||
* - The node operator SHALL create an `updateNode` transaction. | ||
* - The node operator MUST sign this transaction with the active `key` | ||
* for the account assigned as the current "node account". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node account key is only required if that field is changing.
The admin_key
is the signature that is always required.
* for the account assigned as the current "node account". | |
* assigned as the `admin_key`. |
Description:
Related issue(s):
Fixes #16493
Notes for reviewer:
Checklist