Calculate and set the CREATE address for internally created contracts #7293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #7293 +/- ##
==============================================
+ Coverage 0 90.22% +90.22%
- Complexity 0 19116 +19116
==============================================
Files 0 1515 +1515
Lines 0 55935 +55935
Branches 0 5821 +5821
==============================================
+ Hits 0 50469 +50469
- Misses 0 4268 +4268
- Partials 0 1198 +1198
☔ View full report in Codecov by Sentry. |
Signed-off-by: Miroslav Gatsanoga <[email protected]>
tinker-michaelj
previously approved these changes
Jun 30, 2023
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Signed-off-by: Miroslav Gatsanoga <[email protected]>
Signed-off-by: Miroslav Gatsanoga <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
lukelee-sl
approved these changes
Jul 7, 2023
Neeharika-Sompalli
approved these changes
Jul 7, 2023
MiroslavGatsanoga
deleted the
07124-calculate-internal-contract-create-addresses
branch
david-bakin-sl
approved these changes
Jul 7, 2023
...main/java/com/hedera/node/app/service/evm/contracts/operations/HederaEvmCreateOperation.java
Show resolved
Hide resolved
...main/java/com/hedera/node/app/service/evm/contracts/operations/HederaEvmCreateOperation.java
Show resolved
Hide resolved
.../java/com/hedera/node/app/service/evm/contracts/operations/HederaEvmCreateOperationTest.java
Show resolved
Hide resolved
.../java/com/hedera/node/app/service/evm/contracts/operations/HederaEvmCreateOperationTest.java
Show resolved
Hide resolved
...t-clients/src/main/java/com/hedera/services/bdd/spec/assertions/ContractFnResultAsserts.java
Show resolved
Hide resolved
...nts/src/main/java/com/hedera/services/bdd/suites/contract/opcodes/Create2OperationSuite.java
Show resolved
Hide resolved
...ents/src/main/java/com/hedera/services/bdd/suites/contract/opcodes/CreateOperationSuite.java
Show resolved
Hide resolved
mustafauzunn
pushed a commit
that referenced
this pull request
Jul 10, 2023
…#7293) Signed-off-by: Miroslav Gatsanoga <[email protected]>
vtronkov
pushed a commit
that referenced
this pull request
Jul 25, 2023
…#7293) Signed-off-by: Miroslav Gatsanoga <[email protected]> Signed-off-by: Valentin Tronkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Update
HederaEvmCreateOperation.targetContractAddressto calculate theCREATEaddress of a new contract based on the sender's address and nonce.Related issue(s):
Fixes #7124
Notes for reviewer:
Checklist