dapp-feat: finished integrating API methods for TokenQueryContract #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Logan Nguyen <[email protected]>
…ize code reusability Signed-off-by: Logan Nguyen <[email protected]>
Nana-EC
reviewed
Sep 3, 2023
system-contract-dapp-playground/src/api/hedera/tokenQuery-interactions/index.ts
Show resolved
Hide resolved
| TOKEN_KEYS: 'TokenKey', | ||
| CUSTOM_FEES: 'TokenCustomFees', | ||
| TOKEN_EXPIRY: 'TokenExpiryInfo', | ||
| KYC_STATUS: 'TokenDefaultKycStatus', |
There was a problem hiding this comment.
For the kyc and freeze cases i don't believe you've getting the current status. Rather you're getting the default
Suggested change
| KYC_STATUS: 'TokenDefaultKycStatus', | |
| DEFAULT_KYC_STATUS: 'TokenDefaultKycStatus', |
| CUSTOM_FEES: 'TokenCustomFees', | ||
| TOKEN_EXPIRY: 'TokenExpiryInfo', | ||
| KYC_STATUS: 'TokenDefaultKycStatus', | ||
| FREEZE_STATUS: 'TokenDefaultFreezeStatus', |
There was a problem hiding this comment.
Suggested change
| FREEZE_STATUS: 'TokenDefaultFreezeStatus', | |
| DEFAULT_FREEZE_STATUS: 'TokenDefaultFreezeStatus', |
| try { | ||
| let transactionResult; | ||
| switch (API) { | ||
| case 'FREEZE_STATUS': |
There was a problem hiding this comment.
Suggested change
| case 'FREEZE_STATUS': | |
| case 'DEFAULT_FREEZE_STATUS': |
| ); | ||
| break; | ||
|
|
||
| case 'KYC_STATUS': |
There was a problem hiding this comment.
Suggested change
| case 'KYC_STATUS': | |
| case 'DEFAULT_KYC_STATUS': |
system-contract-dapp-playground/src/api/hedera/tokenQuery-interactions/index.ts
Show resolved
Hide resolved
Signed-off-by: Logan Nguyen <[email protected]>
Nana-EC
approved these changes
Sep 4, 2023
quiet-node
deleted the
318-(APIs)-Add-contract-interacting-features-to-TokenQuery-contract
branch
mshakeg
pushed a commit
to mshakeg/hedera-smart-contracts
that referenced
this pull request
Oct 14, 2023
…ashgraph#370) * dapp-feat: finished integrating API methods for TokenQueryContract Signed-off-by: Logan Nguyen <[email protected]> * dapp-feat: added handleContractResponseWithDynamicEventNames to optimize code reusability Signed-off-by: Logan Nguyen <[email protected]> * dapp-update: updated API methods Signed-off-by: Logan Nguyen <[email protected]> --------- Signed-off-by: Logan Nguyen <[email protected]> Signed-off-by: Mo Shaikjee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: finished integrating API methods for TokenQueryContract
Related issue(s): #314
Fixes partial #318
Checklist