Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dapp-feat: TokenGeneralInfo feature complete (#318) #374

Conversation

quiet-node
Copy link
Member

Description: this PR finishes the UI components for TokenGeneralInfo

Related issue(s): #314

Fixes partial #318

Notes for reviewer:

** UI Demo **

Screen.Recording.2023-09-05.at.8.02.12.PM.mov

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node added enhancement New feature or request P2 Tooling tooling labels Sep 6, 2023
@quiet-node quiet-node added this to the 0.5.0 milestone Sep 6, 2023
@quiet-node quiet-node self-assigned this Sep 6, 2023
@quiet-node quiet-node requested a review from a team as a code owner September 6, 2023 01:03
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Test Results

197 tests  ±0   191 ✔️ ±0   6m 31s ⏱️ -9s
  62 suites ±0       6 💤 ±0 
  13 files   ±0       0 ±0 

Results for commit b0edbe1. ± Comparison against base commit 8957a5e.

♻️ This comment has been updated with latest results.

@quiet-node quiet-node merged commit d800234 into main Sep 6, 2023
16 checks passed
@quiet-node quiet-node deleted the 318-(TokenGeneralInfoUI)-Add-contract-interacting-features-to-TokenQuery-contract branch September 6, 2023 17:12
mshakeg pushed a commit to mshakeg/hedera-smart-contracts that referenced this pull request Oct 14, 2023
…ph#374)

* dapp-feat: TokenGeneralInfo feature complete (hashgraph#318)

Signed-off-by: Logan Nguyen <[email protected]>

* dap-fix: fixed tokenInfo callers

Signed-off-by: Logan Nguyen <[email protected]>

---------

Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Mo Shaikjee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 Tooling tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants