dapp-feat: Wipe Cached Transaction Results feature complete (#390) #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Logan Nguyen <[email protected]>
Nana-EC
requested changes
Sep 13, 2023
| */ | ||
| export const clearTransactionCache = () => { | ||
| // loop through localStorage items | ||
| if (typeof localStorage !== 'undefined') { |
There was a problem hiding this comment.
nit: see if this works
Suggested change
| if (typeof localStorage !== 'undefined') { | |
| if (localStorage) { |
| const key = localStorage.key(i); | ||
|
|
||
| // remove items that have keys start with HEDERA | ||
| if (key?.startsWith('HEDERA')) { |
There was a problem hiding this comment.
Make it a constant.
Actually all key names should be drawn from a shared constant
Signed-off-by: Logan Nguyen <[email protected]>
Nana-EC
approved these changes
Sep 14, 2023
quiet-node
deleted the
340-disconnect-feature-should-also-wipe-off-any-records-made-during-smart-contract-interacting-session
branch
mshakeg
pushed a commit
to mshakeg/hedera-smart-contracts
that referenced
this pull request
Oct 14, 2023
…h#390) (hashgraph#398) * dapp-feat: Wipe Cached transaction results feature complete Signed-off-by: Logan Nguyen <[email protected]> * dapp-update: pulled storage keys out of a constant object Signed-off-by: Logan Nguyen <[email protected]> --------- Signed-off-by: Logan Nguyen <[email protected]> Signed-off-by: Mo Shaikjee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR completes the Wipe Cached Transaction Results feature
Related issue(s): #314
Fixes #340
** UI demo **:
Screen.Recording.2023-09-13.at.5.24.00.PM.mov
Notes for reviewer:
Checklist