test: Extend the coverage of account nonce discrepancies tests #703
Conversation
nickeynikolovv
requested review from
AlfredoG87,
attest08,
ebadiere,
georgi-l95,
Ivo-Yankov,
natanasow,
yiliev0,
a team and
Nana-EC
as code owners
artifacts/contracts/discrepancies/nonce/ChainedContracts.sol/ChainedContracts.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Anastasia Kovaliova <[email protected]>
Signed-off-by: Anastasia Kovaliova <[email protected]>
Signed-off-by: Anastasia Kovaliova <[email protected]>
- added and adapted internalTransfer function in internalCallee contract - skipped the blocked tests due to some issues Signed-off-by: Nikolay Nikolov <[email protected]>
- refactored some expected to fail function in test 030 Signed-off-by: Nikolay Nikolov <[email protected]>
Signed-off-by: Nikolay Nikolov <[email protected]>
nickeynikolovv
force-pushed
the
test_677-account-nonce-discrepancies-additional-tests
branch
from
fa0b04c
to
6c4a873
Compare
Signed-off-by: Nikolay Nikolov <[email protected]>
Signed-off-by: Nikolay Nikolov <[email protected]>
This reverts commit 1697084.
Signed-off-by: Nikolay Nikolov <[email protected]>
Signed-off-by: Nikolay Nikolov <[email protected]>
Signed-off-by: Nikolay Nikolov <[email protected]>
test/discrepancies/Nonce.js
Outdated
| erc721Contract = await Utils.deployERC721Contract(); | ||
| tokenAddress = await Utils.createNonFungibleToken( | ||
| tokenCreateContract, | ||
| signers[0].address | ||
| ); |
There was a problem hiding this comment.
Let's avoid overriding variables which are reused in multiple tests - this creates dependencies between the tests where, depending on their execution order, the variable might hold a different value. This reduces the readability of code and makes it hard to trace what is happening without knowing the order of the tests or without going into debug mode.
If we are going to reuse a variable let's assign it only in one place (e.g., in a before() method or, where possible, directly turn it into a const.)
If there are subsets of tests which expect different values here for these variables, we can group them in multiple describes and declare + assign those variables there.
Please check for other such occurrences and try to fix them 🙂. Thank you!
There was a problem hiding this comment.
Unneeded override is removed
|
|
||
| //NONCE-023 | ||
| //need to update the get contract nonce - waiting for SDK | ||
| xit('should update contract nonce for each deployed contract', async function () { |
There was a problem hiding this comment.
Just a lil reminder to enable this later (and other tests waiting for the SDK changes)
-added comments for additional info -removed test 29 Signed-off-by: Nikolay Nikolov <[email protected]>
Signed-off-by: Nikolay Nikolov <[email protected]>
|
@nickeynikolovv please rebase |
|
Hello @nickeynikolovv is this PR still relavant? If so please kindly update the PR. Thanks! |
This PR extends the coverage of account nonce discrepancies tests according to test plan - https://www.notion.so/limechain/Address-account-nonce-discrepancies-Test-Plan-4a186e8cfabc49888ba501750f68d8de?pvs=4