-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: added E2E coverage for isAuthorizedRaw()
in HIP-632.
#997
Merged
quiet-node
merged 2 commits into
main
from
844-feat-examplestests-for-isauthorizedraw-of-hip-632
Oct 31, 2024
Merged
test: added E2E coverage for isAuthorizedRaw()
in HIP-632.
#997
quiet-node
merged 2 commits into
main
from
844-feat-examplestests-for-isauthorizedraw-of-hip-632
Oct 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quiet-node
requested review from
attest08,
georgi-l95,
Ivo-Yankov,
natanasow,
yiliev0 and
a team
as code owners
October 29, 2024 00:07
Test Results 16 files + 5 83 suites +30 11m 47s ⏱️ + 7m 43s Results for commit aaf22fa. ± Comparison against base commit 7c435b1. This pull request removes 1 and adds 171 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
quiet-node
force-pushed
the
844-feat-examplestests-for-isauthorizedraw-of-hip-632
branch
2 times, most recently
from
October 29, 2024 03:19
a0e3a2c
to
e513117
Compare
lukelee-sl
reviewed
Oct 29, 2024
test/system-contracts/hedera-account-service/crypto-allowance/cryptoAllowance.js
Show resolved
Hide resolved
quiet-node
force-pushed
the
844-feat-examplestests-for-isauthorizedraw-of-hip-632
branch
from
October 30, 2024 21:58
b93b70e
to
d9d5a39
Compare
lukelee-sl
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]> Update cryptoAllowance.js Signed-off-by: Logan Nguyen <[email protected]>
quiet-node
force-pushed
the
844-feat-examplestests-for-isauthorizedraw-of-hip-632
branch
from
October 31, 2024 19:50
260dfc4
to
aaf22fa
Compare
quiet-node
deleted the
844-feat-examplestests-for-isauthorizedraw-of-hip-632
branch
October 31, 2024 20:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds e2e test coverage for isAuthorizedRaw() in HIP-632
Related issue(s):
Fixes #844
Notes for reviewer:
Checklist