Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added E2E coverage for isAuthorizedRaw() in HIP-632. #997

Merged

Conversation

quiet-node
Copy link
Member

Description:
This PR adds e2e test coverage for isAuthorizedRaw() in HIP-632

Related issue(s):

Fixes #844

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node added the enhancement New feature or request label Oct 29, 2024
@quiet-node quiet-node added this to the 0.11.0 milestone Oct 29, 2024
@quiet-node quiet-node self-assigned this Oct 29, 2024
@quiet-node quiet-node linked an issue Oct 29, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Oct 29, 2024

Test Results

 16 files  +  5   83 suites  +30   11m 47s ⏱️ + 7m 43s
294 tests +170  288 ✅ +171  6 💤 ±0  0 ❌  - 1 
303 runs  +162  296 ✅ +162  7 💤 +1  0 ❌  - 1 

Results for commit aaf22fa. ± Comparison against base commit 7c435b1.

This pull request removes 1 and adds 171 tests. Note that renamed tests count towards both.
"before all" hook for "should be able to delete token" ‑ TokenManagmentContract Test Suite "before all" hook for "should be able to delete token"
Should NOT allow a non-operator to transfer tokens to another account ‑ @OZERC1155Token Test Suite Should NOT allow a non-operator to transfer tokens to another account
Should NOT allow a spender to spend hbar on behalf of owner without an allowance grant ‑ @CryptoAllowance Test Suite Should NOT allow a spender to spend hbar on behalf of owner without an allowance grant
Should NOT allow an approval on behalf of hbar owner WITHOUT its signature ‑ @CryptoAllowance Test Suite Should NOT allow an approval on behalf of hbar owner WITHOUT its signature
Should NOT be able to send ERC721 token to invalidErc721Receiver via safeTransferFrom ‑ @OZIERC721Receiver Test Suite Should NOT be able to send ERC721 token to invalidErc721Receiver via safeTransferFrom
Should NOT burn insufficient amount of token ‑ @OZERC1155Token Test Suite Should NOT burn insufficient amount of token
Should NOT transfer the ownership to another account if the caller is not owner ‑ @OZERC1155Token Test Suite Should NOT transfer the ownership to another account if the caller is not owner
Should allow a crypto owner contract account to grant an allowance to a spender contract account to transfer allowance to a receiver on behalf of owner contract account ‑ @CryptoAllowance Test Suite Should allow a crypto owner contract account to grant an allowance to a spender contract account to transfer allowance to a receiver on behalf of owner contract account
Should allow an approval on behalf of hbar owner WITH its signature ‑ @CryptoAllowance Test Suite Should allow an approval on behalf of hbar owner WITH its signature
Should allow an operator to transfer a token to another account ‑ @OZERC1155Token Test Suite Should allow an operator to transfer a token to another account
Should allow an operator to transfer tokens in batch to another account ‑ @OZERC1155Token Test Suite Should allow an operator to transfer tokens in batch to another account
…

♻️ This comment has been updated with latest results.

@quiet-node quiet-node force-pushed the 844-feat-examplestests-for-isauthorizedraw-of-hip-632 branch 2 times, most recently from a0e3a2c to e513117 Compare October 29, 2024 03:19
@quiet-node quiet-node force-pushed the 844-feat-examplestests-for-isauthorizedraw-of-hip-632 branch from b93b70e to d9d5a39 Compare October 30, 2024 21:58
Copy link
Member

@lukelee-sl lukelee-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Logan Nguyen <[email protected]>

Update cryptoAllowance.js

Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node quiet-node force-pushed the 844-feat-examplestests-for-isauthorizedraw-of-hip-632 branch from 260dfc4 to aaf22fa Compare October 31, 2024 19:50
@quiet-node quiet-node merged commit 04c5719 into main Oct 31, 2024
32 of 34 checks passed
@quiet-node quiet-node deleted the 844-feat-examplestests-for-isauthorizedraw-of-hip-632 branch October 31, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: examples/tests for isAuthorizedRaw (of HIP-632)
2 participants